Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Issue 2998143002: Reland of Add Jpeg frame writer for test support. (Closed)

Created:
3 years, 4 months ago by ilnik
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add Jpeg frame writer for test support. Also, use it to save worst psnr frame in video quality tests. It is indented that these saved frames from perfbots will be uploaded to the cloud and will be available in chrome perf dashboard. Because of that size of the saved frame is somewhat an issue. Also, y4m is not convenient to view. BUG=webrtc:8030 Review-Url: https://codereview.webrtc.org/2998143002 Cr-Commit-Position: refs/heads/master@{#19450} Committed: https://chromium.googlesource.com/external/webrtc/+/ee42d19b70f0a536bddc3e9a44fd982b4775ffe6

Patch Set 1 : Original CL #

Patch Set 2 : revert to use of gflags everythere #

Patch Set 3 : Fix libjpeg include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -20 lines) Patch
M webrtc/test/BUILD.gn View 1 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/test/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/test/testsupport/frame_writer.h View 1 2 chunks +15 lines, -0 lines 0 comments Download
A webrtc/test/testsupport/jpeg_frame_writer.cc View 1 2 1 chunk +87 lines, -0 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 4 chunks +23 lines, -20 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
ilnik
Created Reland of Add Jpeg frame writer for test support.
3 years, 4 months ago (2017-08-21 08:10:54 UTC) #1
ilnik
sprang, pbos, Please review. Comparing to original reverted cl, here I reverted to use gflags ...
3 years, 4 months ago (2017-08-21 11:43:34 UTC) #8
oprypin_webrtc
Just tried your change on mac, flags work well, so LGTM
3 years, 4 months ago (2017-08-21 12:15:38 UTC) #11
sprang_webrtc
lgtm
3 years, 4 months ago (2017-08-22 08:27:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2998143002/250001
3 years, 4 months ago (2017-08-22 08:39:38 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/20514)
3 years, 4 months ago (2017-08-22 08:45:08 UTC) #16
ilnik
pbos, please give your approval asap, because this cl is blocking other work on flags ...
3 years, 4 months ago (2017-08-22 09:35:14 UTC) #17
oprypin_webrtc
kjellander@, if you have time, could you check this instead? (needed for webrtc/test OWNERS) Note ...
3 years, 4 months ago (2017-08-22 10:44:26 UTC) #19
kjellander_webrtc
lgtm
3 years, 4 months ago (2017-08-22 11:49:20 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2998143002/250001
3 years, 4 months ago (2017-08-22 12:08:39 UTC) #22
commit-bot: I haz the power
3 years, 4 months ago (2017-08-22 14:16:27 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:250001) as
https://chromium.googlesource.com/external/webrtc/+/ee42d19b70f0a536bddc3e9a4...

Powered by Google App Engine
This is Rietveld 408576698