Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2997783002: Move RtcpReportBlocks implementation from ReceiveStatistics to ReceiveStatisticsImpl (Closed)

Created:
3 years, 4 months ago by danilchap
Modified:
3 years, 4 months ago
Reviewers:
eladalon
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move RtcpReportBlocks implementation from ReceiveStatistics to ReceiveStatisticsImpl BUG=webrtc:8016 Review-Url: https://codereview.webrtc.org/2997783002 Cr-Commit-Position: refs/heads/master@{#19327} Committed: https://chromium.googlesource.com/external/webrtc/+/0bc8423fe5e3fa37c0e2cf21752d17f1fd2567d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M webrtc/modules/rtp_rtcp/include/receive_statistics.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
danilchap
3 years, 4 months ago (2017-08-11 14:24:00 UTC) #2
eladalon
lgtm
3 years, 4 months ago (2017-08-11 14:47:13 UTC) #3
eladalon
lgtm lgtm
3 years, 4 months ago (2017-08-11 14:47:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2997783002/1
3 years, 4 months ago (2017-08-11 14:47:22 UTC) #6
eladalon
This interface... :-)
3 years, 4 months ago (2017-08-11 14:47:44 UTC) #7
commit-bot: I haz the power
3 years, 4 months ago (2017-08-11 15:13:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/0bc8423fe5e3fa37c0e2cf217...

Powered by Google App Engine
This is Rietveld 408576698