Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2997763002: [MERGE TO 61] Fix incorrect memset on muted frames. (Closed)

Created:
3 years, 4 months ago by hlundin-webrtc
Modified:
3 years, 4 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, yujo
Target Ref:
refs/branch-heads/61
Project:
webrtc
Visibility:
Public.

Description

[MERGE TO 61] Fix incorrect memset on muted frames. Broken by https://codereview.webrtc.org/2750783004/. Since samples are two bytes each, only half of the buffer was being zeroed, leading to garbage noise. BUG=webrtc:7885, webrtc:7343, chromium:754159 NOTRY=true NOPRESUBMIT=true Change-Id: I46ecf90258b681ccdebbcfadd2e84ac6abadc9fe Reviewed-on: https://chromium-review.googlesource.com/593092 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>; Commit-Queue: Jonathan Yu <yujo@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#19194} Review-Url: https://codereview.webrtc.org/2997763002 Cr-Commit-Position: refs/branch-heads/61@{#3} Cr-Branched-From: 83dc6b6f5380d7c03f5ebfe2553bf4a3147e2d1c-refs/heads/master@{#19063} Committed: https://chromium.googlesource.com/external/webrtc/+/a5903dc69eb7091f7a7b5cb76c827dbaed4a0b63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M webrtc/modules/audio_coding/acm2/audio_coding_module.cc View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
hlundin-webrtc
Karl, please take a look at this merge to M61. Approval was granted in https://bugs.chromium.org/p/chromium/issues/detail?id=754159#c3.
3 years, 4 months ago (2017-08-11 08:31:12 UTC) #3
kwiberg-webrtc
lgtm
3 years, 4 months ago (2017-08-11 08:40:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2997763002/1
3 years, 4 months ago (2017-08-11 08:44:12 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 4 months ago (2017-08-11 08:44:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2997763002/1
3 years, 4 months ago (2017-08-11 09:05:36 UTC) #11
commit-bot: I haz the power
3 years, 4 months ago (2017-08-11 09:05:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/a5903dc69eb7091f7a7b5cb76...

Powered by Google App Engine
This is Rietveld 408576698