Support Java VideoFrames in MediaCodecVideoEncoder.

Support Java VideoFrames in MediaCodecVideoEncoder.

BUG=webrtc:7760
Review-Url: https://codereview.webrtc.org/2997663002
Cr-Commit-Position: refs/heads/master@{#19304}
Committed: https://chromium.googlesource.com/external/webrtc/+/b5f5bdc5cb36fd5b0cb8cc6d22e17d40c33e3192

[sakal, 2017-08-09 12:20:00]

Patchset #2 (id:20001) has been deleted

[sakal, 2017-08-09 12:20:08]

Patchset #1 (id:1) has been deleted

[sakal, 2017-08-09 12:20:30]

sakal@webrtc.org changed reviewers:
+ kthelgason@webrtc.org

[sakal, 2017-08-09 12:20:31]

PTAL

[kthelgason, 2017-08-09 12:53:53]

Some small nits.

https://codereview.webrtc.org/2997663002/diff/60001/webrtc/sdk/android/api/or...
File webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/2997663002/diff/60001/webrtc/sdk/android/api/or...
webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java:606: boolean
encodeFrame(long nativeEncoder, boolean isKeyframe, VideoFrame frame, int
inputBuffer) {
can we have a better name for `inputBuffer`? It's obviously not a buffer since
it's type is `int`

https://codereview.webrtc.org/2997663002/diff/60001/webrtc/sdk/android/api/or...
webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java:631: inputBuffer,
0, width * height * 3 / 2, presentationTimestampUs, 0);
what sort of magic number is `width * height * 3 / 2`?

https://codereview.webrtc.org/2997663002/diff/60001/webrtc/sdk/android/src/jn...
File webrtc/sdk/android/src/jni/native_handle_impl.h (right):

https://codereview.webrtc.org/2997663002/diff/60001/webrtc/sdk/android/src/jn...
webrtc/sdk/android/src/jni/native_handle_impl.h:163: jobject ToJavaFrame(JNIEnv*
jni, webrtc::VideoFrame const& frame) const;
nit: Would prefer `const VideoFrame&` for consistency with rest of codebase.
Don't know the conventions in jni land though.

[sakal, 2017-08-09 13:06:52]

https://codereview.webrtc.org/2997663002/diff/60001/webrtc/sdk/android/api/or...
File webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/2997663002/diff/60001/webrtc/sdk/android/api/or...
webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java:606: boolean
encodeFrame(long nativeEncoder, boolean isKeyframe, VideoFrame frame, int
inputBuffer) {
On 2017/08/09 12:53:53, kthelgason wrote:
> can we have a better name for `inputBuffer`? It's obviously not a buffer since
> it's type is `int`

Renamed to bufferIndex.

https://codereview.webrtc.org/2997663002/diff/60001/webrtc/sdk/android/api/or...
webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java:631: inputBuffer,
0, width * height * 3 / 2, presentationTimestampUs, 0);
On 2017/08/09 12:53:53, kthelgason wrote:
> what sort of magic number is `width * height * 3 / 2`?

This matches the old code but the logic is moved from C++ to Java side. I added
a comment.

https://codereview.webrtc.org/2997663002/diff/60001/webrtc/sdk/android/src/jn...
File webrtc/sdk/android/src/jni/native_handle_impl.h (right):

https://codereview.webrtc.org/2997663002/diff/60001/webrtc/sdk/android/src/jn...
webrtc/sdk/android/src/jni/native_handle_impl.h:163: jobject ToJavaFrame(JNIEnv*
jni, webrtc::VideoFrame const& frame) const;
On 2017/08/09 12:53:53, kthelgason wrote:
> nit: Would prefer `const VideoFrame&` for consistency with rest of codebase.
> Don't know the conventions in jni land though.

Done.

[sakal, 2017-08-09 13:11:41]

Patchset #3 (id:80001) has been deleted

[kthelgason, 2017-08-10 09:34:11]

lgtm

[sakal, 2017-08-10 10:15:32]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2017-08-10 10:15:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-10 10:17:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-10 10:17:51]

Try jobs failed on following builders:
  linux_msan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/22659)

[sakal, 2017-08-10 10:55:45]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2017-08-10 10:55:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-10 11:15:42]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1502362545761350,
"parent_rev": "351424e942323185c24e92516ecb2a4c454db9f0", "commit_rev":
"b5f5bdc5cb36fd5b0cb8cc6d22e17d40c33e3192"}

[commit-bot: I haz the power, 2017-08-10 11:15:47]

Description was changed from

==========
Support Java VideoFrames in MediaCodecVideoEncoder.

BUG=webrtc:7760
==========

to

==========
Support Java VideoFrames in MediaCodecVideoEncoder.

BUG=webrtc:7760

Review-Url: https://codereview.webrtc.org/2997663002
Cr-Commit-Position: refs/heads/master@{#19304}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b5f5bdc5cb36fd5b0cb8cc6d2...
==========

[commit-bot: I haz the power, 2017-08-10 11:15:49]

Committed patchset #3 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/b5f5bdc5cb36fd5b0cb8cc6d2...