Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2997453002: ObjC: Remove RTCVideoFrame I420 functions (Closed)

Created:
3 years, 4 months ago by magjed_webrtc
Modified:
3 years, 4 months ago
Reviewers:
andersc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

ObjC: Remove RTCVideoFrame I420 functions Access to I420 data should be done on an RTCI420Buffer that can be accessed through the toI420 method, and not on an RTCVideoFrame directly. BUG=webrtc:7785 Review-Url: https://codereview.webrtc.org/2997453002 Cr-Commit-Position: refs/heads/master@{#19431} Committed: https://chromium.googlesource.com/external/webrtc/+/139cf382230ec7b8b9a90c1fd106bd8d3f0d4a0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -61 lines) Patch
M webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoFrame.mm View 1 chunk +0 lines, -48 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoFrame.h View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
magjed_webrtc
Anders - please take a look.
3 years, 4 months ago (2017-08-04 12:09:02 UTC) #7
andersc
lgtm
3 years, 4 months ago (2017-08-04 17:00:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2997453002/1
3 years, 4 months ago (2017-08-21 13:25:54 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2017-08-21 14:31:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/139cf382230ec7b8b9a90c1fd...

Powered by Google App Engine
This is Rietveld 408576698