Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2997383002: Use fake audio device in peerconnectioninterface_unittest.cc. (Closed)

Created:
3 years, 4 months ago by Taylor Brandstetter
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use fake audio device in peerconnectioninterface_unittest.cc. This test doesn't actually send/receive any audio; it's only testing the interface layer. But the fact that it was creating/destroying real audio devices repeatedly caused problems when tests were run in parallel. So switching to a fake audio device solves this. BUG=webrtc:7806 Review-Url: https://codereview.webrtc.org/2997383002 Cr-Commit-Position: refs/heads/master@{#19472} Committed: https://chromium.googlesource.com/external/webrtc/+/d7850b299bed6af1598800b051c9efda155d97b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M webrtc/pc/peerconnectioninterface_unittest.cc View 9 chunks +15 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Taylor Brandstetter
PTAL
3 years, 4 months ago (2017-08-23 02:26:19 UTC) #2
pthatcher1
lgtm
3 years, 4 months ago (2017-08-23 04:03:17 UTC) #3
henrika_webrtc
lgtm
3 years, 4 months ago (2017-08-23 08:55:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2997383002/1
3 years, 4 months ago (2017-08-23 16:52:08 UTC) #6
commit-bot: I haz the power
3 years, 4 months ago (2017-08-23 17:59:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d7850b299bed6af1598800b05...

Powered by Google App Engine
This is Rietveld 408576698