Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2997343002: [wpr-go] Include stderr in error msg (Closed)

Created:
3 years, 4 months ago by xunjieli
Modified:
3 years, 4 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M telemetry/telemetry/internal/binary_dependencies.json View 1 chunk +8 lines, -8 lines 0 comments Download
M web_page_replay_go/src/webpagereplay/adb_cert_installer.go View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
xunjieli
Ned, I mis-read your suggestion. Including the stderr from cmd should give us more information ...
3 years, 4 months ago (2017-08-22 00:19:53 UTC) #2
nednguyen
lgtm
3 years, 4 months ago (2017-08-22 00:32:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2997343002/1
3 years, 4 months ago (2017-08-22 11:53:58 UTC) #9
commit-bot: I haz the power
3 years, 4 months ago (2017-08-22 11:55:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698