Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 2997023002: Remove dep on system_wrappers for apprtc and use only framework. (Closed)

Created:
3 years, 4 months ago by kthelgason
Modified:
3 years, 4 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, alexnarest
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove dep on system_wrappers for apprtc and use only framework. This resolves an issue where setting field trials from AppRTCMobile would not affect WebRTC Core as the two are linked with different instances of the field_trials binary. BUG=webrtc:8106 Review-Url: https://codereview.webrtc.org/2997023002 Cr-Commit-Position: refs/heads/master@{#19372} Committed: https://chromium.googlesource.com/external/webrtc/+/5901d9dfe072e9e4b13459e122b26f6ff327fe78

Patch Set 1 #

Patch Set 2 : fix oops #

Patch Set 3 : re-add system_wrappers for mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M webrtc/examples/BUILD.gn View 1 2 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
kthelgason
3 years, 4 months ago (2017-08-16 12:00:16 UTC) #14
magjed_webrtc
lgtm
3 years, 4 months ago (2017-08-16 14:02:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2997023002/40001
3 years, 4 months ago (2017-08-16 14:25:42 UTC) #17
commit-bot: I haz the power
3 years, 4 months ago (2017-08-16 14:28:12 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/5901d9dfe072e9e4b13459e12...

Powered by Google App Engine
This is Rietveld 408576698