Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 2996993002: Revert of L16 implementation of the Audio{En,De}coderFactoryTemplate APIs (Closed)

Created:
3 years, 4 months ago by charujain
Modified:
3 years, 4 months ago
Reviewers:
ossu, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of L16 implementation of the Audio{En,De}coderFactoryTemplate APIs (patchset #5 id:80001 of https://codereview.webrtc.org/2995523002/ ) Reason for revert: Breaks compilation in google3. Original issue's description: > L16 implementation of the Audio{En,De}coderFactoryTemplate APIs > > BUG=webrtc:7836, webrtc:7842 > > Review-Url: https://codereview.webrtc.org/2995523002 > Cr-Commit-Position: refs/heads/master@{#19354} > Committed: https://chromium.googlesource.com/external/webrtc/+/edff94df62d5cc0563430ed8d5e2ba8c9f88f7dd TBR=ossu@webrtc.org,kwiberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7836, webrtc:7842 Review-Url: https://codereview.webrtc.org/2996993002 Cr-Commit-Position: refs/heads/master@{#19356} Committed: https://chromium.googlesource.com/external/webrtc/+/ac31526bb5416af4c100787d3826fa582cf21726

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -322 lines) Patch
D webrtc/api/audio_codecs/L16/BUILD.gn View 1 chunk +0 lines, -39 lines 0 comments Download
D webrtc/api/audio_codecs/L16/audio_decoder_L16.h View 1 chunk +0 lines, -44 lines 0 comments Download
D webrtc/api/audio_codecs/L16/audio_decoder_L16.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D webrtc/api/audio_codecs/L16/audio_encoder_L16.h View 1 chunk +0 lines, -48 lines 0 comments Download
D webrtc/api/audio_codecs/L16/audio_encoder_L16.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M webrtc/api/audio_codecs/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/api/audio_codecs/test/audio_decoder_factory_template_unittest.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/pcm16b/pcm16b_common.h View 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/pcm16b/pcm16b_common.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
charujain
Created Revert of L16 implementation of the Audio{En,De}coderFactoryTemplate APIs
3 years, 4 months ago (2017-08-15 14:49:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2996993002/1
3 years, 4 months ago (2017-08-15 14:50:06 UTC) #3
commit-bot: I haz the power
3 years, 4 months ago (2017-08-15 14:50:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/ac31526bb5416af4c100787d3...

Powered by Google App Engine
This is Rietveld 408576698