Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2996883002: In bwe test Collect receive statistic using GetReportBlocks collector (Closed)

Created:
3 years, 4 months ago by danilchap
Modified:
3 years, 3 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

In bwe tests Collect receive statistic using GetReportBlocks collector instead of GetActiveStatistcian BUG=webrtc:8016 Review-Url: https://codereview.webrtc.org/2996883002 Cr-Commit-Position: refs/heads/master@{#19685} Committed: https://chromium.googlesource.com/external/webrtc/+/7eb938d4c065014a6d33a4258b6e85e28de28359

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -18 lines) Patch
M webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc View 2 chunks +8 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
danilchap
Would like to replace GetActiveStatistician getter with RtcpReportBlocks (same core functionality) in receive statistics object. ...
3 years, 4 months ago (2017-08-11 13:59:40 UTC) #3
danilchap
ping, Philip, are you ok reviewing this change or should I ask another owner?
3 years, 3 months ago (2017-09-05 09:19:04 UTC) #5
philipel
lgtm
3 years, 3 months ago (2017-09-05 10:23:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2996883002/20001
3 years, 3 months ago (2017-09-05 10:35:58 UTC) #8
commit-bot: I haz the power
3 years, 3 months ago (2017-09-05 11:02:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/7eb938d4c065014a6d33a4258...

Powered by Google App Engine
This is Rietveld 408576698