Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2996343002: MB: Add configs for Windows bots enforcing MSVC compilation. (Closed)

Created:
3 years, 4 months ago by kjellander_webrtc
Modified:
3 years, 4 months ago
Reviewers:
mbonadei
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

MB: Add configs for Windows bots enforcing MSVC compilation. BUG=chromium:757293 NOTRY=True Review-Url: https://codereview.webrtc.org/2996343002 Cr-Commit-Position: refs/heads/master@{#19422} Committed: https://chromium.googlesource.com/external/webrtc/+/c2d4d577552c1cac19155a2a36796cd7435554e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M tools_webrtc/mb/mb_config.pyl View 4 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kjellander_webrtc
3 years, 4 months ago (2017-08-21 09:53:27 UTC) #2
mbonadei
On 2017/08/21 09:53:27, kjellander_webrtc wrote: LGTM.
3 years, 4 months ago (2017-08-21 09:54:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2996343002/1
3 years, 4 months ago (2017-08-21 09:55:21 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-08-21 09:58:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c2d4d577552c1cac19155a2a3...

Powered by Google App Engine
This is Rietveld 408576698