Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2995993002: L16 implementation of the Audio{En,De}coderFactoryTemplate APIs (Closed)

Created:
3 years, 4 months ago by kwiberg-webrtc
Modified:
3 years, 4 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

L16 implementation of the Audio{En,De}coderFactoryTemplate APIs (This is a re-land of https://codereview.webrtc.org/2995523002, with a narrowing conversion removed.) BUG=webrtc:7836, webrtc:7842 Review-Url: https://codereview.webrtc.org/2995993002 Cr-Commit-Position: refs/heads/master@{#19369} Committed: https://chromium.googlesource.com/external/webrtc/+/7ea6e59735248059688bae7f6fad78112c38045f

Patch Set 1 : original CL #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -0 lines) Patch
A webrtc/api/audio_codecs/L16/BUILD.gn View 1 chunk +39 lines, -0 lines 0 comments Download
A webrtc/api/audio_codecs/L16/audio_decoder_L16.h View 1 chunk +44 lines, -0 lines 0 comments Download
A webrtc/api/audio_codecs/L16/audio_decoder_L16.cc View 1 chunk +42 lines, -0 lines 0 comments Download
A webrtc/api/audio_codecs/L16/audio_encoder_L16.h View 1 chunk +48 lines, -0 lines 0 comments Download
A webrtc/api/audio_codecs/L16/audio_encoder_L16.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M webrtc/api/audio_codecs/test/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/api/audio_codecs/test/audio_decoder_factory_template_unittest.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/pcm16b/pcm16b_common.h View 1 chunk +22 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/pcm16b/pcm16b_common.cc View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (19 generated)
kwiberg-webrtc
3 years, 4 months ago (2017-08-16 05:13:56 UTC) #17
ossu
Let's do it! LGTM!
3 years, 4 months ago (2017-08-16 11:57:24 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2995993002/80001
3 years, 4 months ago (2017-08-16 11:59:52 UTC) #20
commit-bot: I haz the power
3 years, 4 months ago (2017-08-16 13:13:03 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/7ea6e59735248059688bae7f6...

Powered by Google App Engine
This is Rietveld 408576698