Decoupling objc_videotoolbox from non Obj-C code

webrtc/sdk/BUILD.gn

Index: webrtc/sdk/BUILD.gn
diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn
index 3809aa112c2ecafe42e45b535d3d901856de28a2..45a9ff7a8d06b0cda6a72d26c0f36aa2aabff7e6 100644
--- a/webrtc/sdk/BUILD.gn
+++ b/webrtc/sdk/BUILD.gn
@@ -695,14 +695,30 @@ if (is_ios || is_mac) {
       libs = [ "CoreVideo.framework" ]
     }
 
-    rtc_static_library("objc_videotoolbox") {
+    rtc_static_library("video_toolbox_cc") {

[mbonadei, 2017/08/15 15:01:52]

kjellander@: Do you think it is a good name or should I change it?

[kjellander_webrtc, 2017/08/15 16:16:24]

Restrict visibility?

[kjellander_webrtc, 2017/08/15 16:16:24]

It's good. The other ones should be changed in another cl.

[mbonadei, 2017/08/16 07:52:30]

Done, good catch!

       sources = [
-        "objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm",
-        "objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm",
         "objc/Framework/Classes/VideoToolbox/helpers.cc",
         "objc/Framework/Classes/VideoToolbox/helpers.h",
         "objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc",
         "objc/Framework/Classes/VideoToolbox/nalu_rewriter.h",
+      ]
+      deps = [
+        "../common_video",
+        "../modules:module_api",
+        "../modules/video_coding:webrtc_h264",
+        "../rtc_base:rtc_base_approved",
+      ]
+      if (!build_with_chromium && is_clang) {
+        # Suppress warnings from the Chromium Clang plugin
+        # (bugs.webrtc.org/163).
+        suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+      }
+    }
+
+    rtc_static_library("objc_videotoolbox") {
+      sources = [
+        "objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm",
+        "objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm",
         "objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.h",
         "objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm",
         "objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.h",
@@ -716,6 +732,7 @@ if (is_ios || is_mac) {
         ":objc_common",
         ":objc_video",
         ":objc_videotracksource",
+        ":video_toolbox_cc",
         "../api/video_codecs:video_codecs_api",
         "../common_video",
         "../media:rtc_media",