Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2995673002: Removing NO_SOUND_SYSTEM (Closed)

Created:
3 years, 4 months ago by mbonadei
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing NO_SOUND_SYSTEM This is never used in WebRTC, so we can probably remove it. BUG=webrtc:8082 NOTRY=True Review-Url: https://codereview.webrtc.org/2995673002 Cr-Commit-Position: refs/heads/master@{#19329} Committed: https://chromium.googlesource.com/external/webrtc/+/455372d7b24df37e4cb943eba7d87a4fdc31ed20

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
mbonadei
3 years, 4 months ago (2017-08-09 15:37:44 UTC) #2
ehmaldonado_webrtc
On 2017/08/09 15:37:44, mbonadei wrote: lgtm
3 years, 4 months ago (2017-08-10 11:25:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2995673002/1
3 years, 4 months ago (2017-08-10 11:26:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/20003)
3 years, 4 months ago (2017-08-10 11:32:00 UTC) #8
mbonadei
On 2017/08/10 11:32:00, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 4 months ago (2017-08-10 11:35:27 UTC) #10
kjellander_webrtc
lgtm, I also cannot find any trace of this ever being used.
3 years, 4 months ago (2017-08-14 07:04:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2995673002/1
3 years, 4 months ago (2017-08-14 07:38:06 UTC) #13
commit-bot: I haz the power
3 years, 4 months ago (2017-08-14 07:41:06 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/455372d7b24df37e4cb943eba...

Powered by Google App Engine
This is Rietveld 408576698