Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 2995433002: Rename ViEEncoder to VideoStreamEncoder. (Closed)

Created:
3 years, 4 months ago by mflodman
Modified:
3 years, 4 months ago
Reviewers:
brandtr
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename ViEEncoder to VideoStreamEncoder This CL: - Renames the ViEEncoder class to VideoStreamEncoder, according to discussions. - Renames variables 'vie_encode' to 'video_stream_encoder'. - Formatting to match style guide. - No other changes. BUG=webrtc:8064 Review-Url: https://codereview.webrtc.org/2995433002 Cr-Commit-Position: refs/heads/master@{#19237} Committed: https://chromium.googlesource.com/external/webrtc/+/cc3d442469a3aed337e006694938b138157097f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+728 lines, -5366 lines) Patch
M webrtc/call/call_perf_tests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/fake_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/encoder_rtcp_feedback.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/encoder_rtcp_feedback.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M webrtc/video/encoder_rtcp_feedback_unittest.cc View 2 chunks +12 lines, -11 lines 0 comments Download
M webrtc/video/send_statistics_proxy.h View 3 chunks +14 lines, -10 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 3 chunks +11 lines, -10 lines 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 20 chunks +40 lines, -40 lines 0 comments Download
M webrtc/video/video_send_stream.h View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 20 chunks +41 lines, -35 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/video/video_stream_encoder.h View 5 chunks +18 lines, -18 lines 0 comments Download
A + webrtc/video/video_stream_encoder.cc View 37 chunks +110 lines, -94 lines 0 comments Download
A + webrtc/video/video_stream_encoder_unittest.cc View 155 chunks +461 lines, -419 lines 0 comments Download
D webrtc/video/vie_encoder.h View 1 chunk +0 lines, -316 lines 0 comments Download
D webrtc/video/vie_encoder.cc View 1 chunk +0 lines, -1250 lines 0 comments Download
D webrtc/video/vie_encoder_unittest.cc View 1 chunk +0 lines, -3143 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
mflodman
Rasmus, Can you take a look at this CL, renaming ViEEncoder according to our discussions ...
3 years, 4 months ago (2017-08-03 13:48:28 UTC) #5
brandtr
lgtm, but please update the first line of the CL description to summarize the name ...
3 years, 4 months ago (2017-08-03 14:36:26 UTC) #8
mflodman
On 2017/08/03 14:36:26, brandtr wrote: > lgtm, but please update the first line of the ...
3 years, 4 months ago (2017-08-03 15:09:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2995433002/1
3 years, 4 months ago (2017-08-03 15:09:56 UTC) #12
commit-bot: I haz the power
3 years, 4 months ago (2017-08-03 15:27:58 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/cc3d442469a3aed337e006694...

Powered by Google App Engine
This is Rietveld 408576698