Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2995403002: Remove unnecessary RTPFragmentationHeader from VideoProcessor callbacks. (Closed)

Created:
3 years, 4 months ago by brandtr
Modified:
3 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unnecessary RTPFragmentationHeader from VideoProcessor callbacks. This test is and should be independent of RTP, so we don't need the information provided in this struct. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2995403002 Cr-Commit-Position: refs/heads/master@{#19443} Committed: https://chromium.googlesource.com/external/webrtc/+/4553562fe3be5e61ebde13dd2c0850cbce49d052

Patch Set 1 #

Total comments: 3

Patch Set 2 : asapersson comments 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -22 lines) Patch
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 5 chunks +7 lines, -13 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 1 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
brandtr
3 years, 4 months ago (2017-08-22 09:41:50 UTC) #2
åsapersson
lgtm https://codereview.webrtc.org/2995403002/diff/1/webrtc/modules/video_coding/codecs/test/videoprocessor.cc File webrtc/modules/video_coding/codecs/test/videoprocessor.cc (right): https://codereview.webrtc.org/2995403002/diff/1/webrtc/modules/video_coding/codecs/test/videoprocessor.cc#newcode396 webrtc/modules/video_coding/codecs/test/videoprocessor.cc:396: // Keep track of if frames are lost ...
3 years, 4 months ago (2017-08-22 09:49:42 UTC) #3
brandtr
https://codereview.webrtc.org/2995403002/diff/1/webrtc/modules/video_coding/codecs/test/videoprocessor.cc File webrtc/modules/video_coding/codecs/test/videoprocessor.cc (right): https://codereview.webrtc.org/2995403002/diff/1/webrtc/modules/video_coding/codecs/test/videoprocessor.cc#newcode396 webrtc/modules/video_coding/codecs/test/videoprocessor.cc:396: // Keep track of if frames are lost due ...
3 years, 4 months ago (2017-08-22 09:51:59 UTC) #4
brandtr
https://codereview.webrtc.org/2995403002/diff/1/webrtc/modules/video_coding/codecs/test/videoprocessor.cc File webrtc/modules/video_coding/codecs/test/videoprocessor.cc (right): https://codereview.webrtc.org/2995403002/diff/1/webrtc/modules/video_coding/codecs/test/videoprocessor.cc#newcode396 webrtc/modules/video_coding/codecs/test/videoprocessor.cc:396: // Keep track of if frames are lost due ...
3 years, 4 months ago (2017-08-22 09:53:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2995403002/20001
3 years, 4 months ago (2017-08-22 10:30:47 UTC) #12
commit-bot: I haz the power
3 years, 4 months ago (2017-08-22 10:33:18 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/4553562fe3be5e61ebde13dd2...

Powered by Google App Engine
This is Rietveld 408576698