Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1300)

Unified Diff: webrtc/test/testsupport/test_output_unittest.cc

Issue 2995363002: Replace gflags usages with rtc_base/flags in all targets based on test_main (Closed)
Patch Set: Fix string use after free Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/test/testsupport/test_output.cc ('k') | webrtc/video/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/test/testsupport/test_output_unittest.cc
diff --git a/webrtc/test/testsupport/test_output_unittest.cc b/webrtc/test/testsupport/test_output_unittest.cc
index 511ce6f750f2107e9f99755af8b60096eb0cef5e..a082dc1ec8ed16f9511b3dbd8077028b9b0edaa6 100644
--- a/webrtc/test/testsupport/test_output_unittest.cc
+++ b/webrtc/test/testsupport/test_output_unittest.cc
@@ -14,8 +14,8 @@
#include <string>
-#include "gflags/gflags.h"
#include "webrtc/rtc_base/file.h"
+#include "webrtc/rtc_base/flags.h"
#include "webrtc/rtc_base/pathutils.h"
#include "webrtc/rtc_base/platform_file.h"
#include "webrtc/test/gtest.h"
@@ -26,10 +26,10 @@ namespace webrtc {
namespace test {
TEST(IsolatedOutputTest, ShouldRejectInvalidIsolatedOutDir) {
- std::string backup = FLAGS_test_output_dir;
- FLAGS_test_output_dir = "";
+ const char* backup = FLAG_test_output_dir;
+ FLAG_test_output_dir = "";
ASSERT_FALSE(WriteToTestOutput("a-file", "some-contents"));
- FLAGS_test_output_dir = backup;
+ FLAG_test_output_dir = backup;
}
TEST(IsolatedOutputTest, ShouldRejectInvalidFileName) {
@@ -42,7 +42,7 @@ TEST(IsolatedOutputTest, ShouldBeAbleToWriteContent) {
const char* filename = "a-file";
const char* content = "some-contents";
if (WriteToTestOutput(filename, content)) {
- rtc::Pathname out_file(FLAGS_test_output_dir, filename);
+ rtc::Pathname out_file(FLAG_test_output_dir, filename);
rtc::File input = rtc::File::Open(out_file);
EXPECT_TRUE(input.IsOpen());
EXPECT_TRUE(input.Seek(0));
« no previous file with comments | « webrtc/test/testsupport/test_output.cc ('k') | webrtc/video/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698