Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Side by Side Diff: webrtc/test/testsupport/test_output_unittest.cc

Issue 2995363002: Replace gflags usages with rtc_base/flags in all targets based on test_main (Closed)
Patch Set: Fix string use after free Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/test/testsupport/test_output.cc ('k') | webrtc/video/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/test/testsupport/test_output.h" 11 #include "webrtc/test/testsupport/test_output.h"
12 12
13 #include <string.h> 13 #include <string.h>
14 14
15 #include <string> 15 #include <string>
16 16
17 #include "gflags/gflags.h"
18 #include "webrtc/rtc_base/file.h" 17 #include "webrtc/rtc_base/file.h"
18 #include "webrtc/rtc_base/flags.h"
19 #include "webrtc/rtc_base/pathutils.h" 19 #include "webrtc/rtc_base/pathutils.h"
20 #include "webrtc/rtc_base/platform_file.h" 20 #include "webrtc/rtc_base/platform_file.h"
21 #include "webrtc/test/gtest.h" 21 #include "webrtc/test/gtest.h"
22 22
23 DECLARE_string(test_output_dir); 23 DECLARE_string(test_output_dir);
24 24
25 namespace webrtc { 25 namespace webrtc {
26 namespace test { 26 namespace test {
27 27
28 TEST(IsolatedOutputTest, ShouldRejectInvalidIsolatedOutDir) { 28 TEST(IsolatedOutputTest, ShouldRejectInvalidIsolatedOutDir) {
29 std::string backup = FLAGS_test_output_dir; 29 const char* backup = FLAG_test_output_dir;
30 FLAGS_test_output_dir = ""; 30 FLAG_test_output_dir = "";
31 ASSERT_FALSE(WriteToTestOutput("a-file", "some-contents")); 31 ASSERT_FALSE(WriteToTestOutput("a-file", "some-contents"));
32 FLAGS_test_output_dir = backup; 32 FLAG_test_output_dir = backup;
33 } 33 }
34 34
35 TEST(IsolatedOutputTest, ShouldRejectInvalidFileName) { 35 TEST(IsolatedOutputTest, ShouldRejectInvalidFileName) {
36 ASSERT_FALSE(WriteToTestOutput(nullptr, "some-contents")); 36 ASSERT_FALSE(WriteToTestOutput(nullptr, "some-contents"));
37 ASSERT_FALSE(WriteToTestOutput("", "some-contents")); 37 ASSERT_FALSE(WriteToTestOutput("", "some-contents"));
38 } 38 }
39 39
40 // Sets isolated_out_dir=<a-writable-path> to execute this test. 40 // Sets isolated_out_dir=<a-writable-path> to execute this test.
41 TEST(IsolatedOutputTest, ShouldBeAbleToWriteContent) { 41 TEST(IsolatedOutputTest, ShouldBeAbleToWriteContent) {
42 const char* filename = "a-file"; 42 const char* filename = "a-file";
43 const char* content = "some-contents"; 43 const char* content = "some-contents";
44 if (WriteToTestOutput(filename, content)) { 44 if (WriteToTestOutput(filename, content)) {
45 rtc::Pathname out_file(FLAGS_test_output_dir, filename); 45 rtc::Pathname out_file(FLAG_test_output_dir, filename);
46 rtc::File input = rtc::File::Open(out_file); 46 rtc::File input = rtc::File::Open(out_file);
47 EXPECT_TRUE(input.IsOpen()); 47 EXPECT_TRUE(input.IsOpen());
48 EXPECT_TRUE(input.Seek(0)); 48 EXPECT_TRUE(input.Seek(0));
49 uint8_t buffer[32]; 49 uint8_t buffer[32];
50 EXPECT_EQ(input.Read(buffer, strlen(content)), strlen(content)); 50 EXPECT_EQ(input.Read(buffer, strlen(content)), strlen(content));
51 buffer[strlen(content)] = 0; 51 buffer[strlen(content)] = 0;
52 EXPECT_EQ(std::string(content), 52 EXPECT_EQ(std::string(content),
53 std::string(reinterpret_cast<char*>(buffer))); 53 std::string(reinterpret_cast<char*>(buffer)));
54 input.Close(); 54 input.Close();
55 55
56 EXPECT_TRUE(rtc::File::Remove(out_file)); 56 EXPECT_TRUE(rtc::File::Remove(out_file));
57 } 57 }
58 } 58 }
59 59
60 } // namespace test 60 } // namespace test
61 } // namespace webrtc 61 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/test/testsupport/test_output.cc ('k') | webrtc/video/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698