Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2995213002:
TestVp8Impl: Remove unused arguments and member variable. (Closed)
|
Created:
3 years, 4 months ago by åsapersson Modified:
3 years, 4 months ago Reviewers:
brandtr CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionTestVp8Impl: Remove unused arguments and member variable.
Make WaitForEncodedFrame void.
Verify QP for each encoded frame.
Add SetupCodecSettings.
BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/2995213002
Cr-Commit-Position: refs/heads/master@{#19426}
Committed: https://chromium.googlesource.com/external/webrtc/+/0069b4517966c3a547dafcf4086f9ff30f1bbfc7
Patch Set 1 #Patch Set 2 #
Total comments: 4
Patch Set 3 : address comments #Messages
Total messages: 22 (17 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== Minor changes to TestVp8Impl. BUG=webrtc:6634 ========== to ========== Minor changes to TestVp8Impl. Remove unused arguments and member variable. BUG=none ==========
Description was changed from ========== Minor changes to TestVp8Impl. Remove unused arguments and member variable. BUG=none ========== to ========== TestVp8Impl: Remove unused arguments and member variable. Make WaitForEncodedFrame void. Verify QP for each encoded frame. Add SetupCodecSettings. BUG=none ==========
Patchset #2 (id:60001) has been deleted
asapersson@webrtc.org changed reviewers: + brandtr@webrtc.org
lgtm https://codereview.webrtc.org/2995213002/diff/80001/webrtc/modules/video_codi... File webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc (right): https://codereview.webrtc.org/2995213002/diff/80001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:64: void VerifyQp(const EncodedImage& encoded_frame) const { Maybe add a comment what this function does? https://codereview.webrtc.org/2995213002/diff/80001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:271: const int kBitrate = 300; kBitrateKbps
Patchset #3 (id:100001) has been deleted
https://codereview.webrtc.org/2995213002/diff/80001/webrtc/modules/video_codi... File webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc (right): https://codereview.webrtc.org/2995213002/diff/80001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:64: void VerifyQp(const EncodedImage& encoded_frame) const { On 2017/08/21 11:27:33, brandtr wrote: > Maybe add a comment what this function does? Renamed function. https://codereview.webrtc.org/2995213002/diff/80001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:271: const int kBitrate = 300; On 2017/08/21 11:27:33, brandtr wrote: > kBitrateKbps Done.
Description was changed from ========== TestVp8Impl: Remove unused arguments and member variable. Make WaitForEncodedFrame void. Verify QP for each encoded frame. Add SetupCodecSettings. BUG=none ========== to ========== TestVp8Impl: Remove unused arguments and member variable. Make WaitForEncodedFrame void. Verify QP for each encoded frame. Add SetupCodecSettings. BUG=webrtc:6634 ==========
Description was changed from ========== TestVp8Impl: Remove unused arguments and member variable. Make WaitForEncodedFrame void. Verify QP for each encoded frame. Add SetupCodecSettings. BUG=webrtc:6634 ========== to ========== TestVp8Impl: Remove unused arguments and member variable. Make WaitForEncodedFrame void. Verify QP for each encoded frame. Add SetupCodecSettings. BUG=webrtc:6634 ==========
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by asapersson@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org Link to the patchset: https://codereview.webrtc.org/2995213002/#ps120001 (title: "address comments")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1503319694785120,
"parent_rev": "228fb0e1ec5f25018d112bf891bf8cca4a038fed", "commit_rev":
"0069b4517966c3a547dafcf4086f9ff30f1bbfc7"}
Message was sent while issue was closed.
Description was changed from ========== TestVp8Impl: Remove unused arguments and member variable. Make WaitForEncodedFrame void. Verify QP for each encoded frame. Add SetupCodecSettings. BUG=webrtc:6634 ========== to ========== TestVp8Impl: Remove unused arguments and member variable. Make WaitForEncodedFrame void. Verify QP for each encoded frame. Add SetupCodecSettings. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2995213002 Cr-Commit-Position: refs/heads/master@{#19426} Committed: https://chromium.googlesource.com/external/webrtc/+/0069b4517966c3a547dafcf40... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:120001) as https://chromium.googlesource.com/external/webrtc/+/0069b4517966c3a547dafcf40... |
