Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 2995033002: Use bundled SDK 10.12 toolchain for Mac and iOS. (Closed)

Created:
3 years, 4 months ago by kjellander_webrtc
Modified:
3 years, 3 months ago
Reviewers:
mbonadei
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use bundled SDK 10.12 toolchain for Mac and iOS. BUG=webrtc:6608, webrtc:8099, chromium:659726, chromium:763440 TBR=mbonadei@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2995033002 Cr-Commit-Position: refs/heads/master@{#19753} Committed: https://chromium.googlesource.com/external/webrtc/+/ec2c93e9479c3c6b8abffa2252a15475ab75f6dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M .gn View 1 chunk +1 line, -1 line 0 comments Download
M DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M build_overrides/build.gni View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
kjellander_webrtc
I'm submitting this as I believe the failures are only due to LUCI emulation mode ...
3 years, 3 months ago (2017-09-08 17:49:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2995033002/1
3 years, 3 months ago (2017-09-08 17:49:45 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/ec2c93e9479c3c6b8abffa2252a15475ab75f6dd
3 years, 3 months ago (2017-09-08 17:52:24 UTC) #15
mbonadei
3 years, 3 months ago (2017-09-08 19:51:51 UTC) #16
Message was sent while issue was closed.
Great!

LGTM!

Powered by Google App Engine
This is Rietveld 408576698