Add video timing frames to set of default RTP header extensions

Add video timing frames to set of default RTP header extensions

BUG=webrtc:7594
Review-Url: https://codereview.webrtc.org/2994893002
Cr-Commit-Position: refs/heads/master@{#19449}
Committed: https://chromium.googlesource.com/external/webrtc/+/eb13f5e40048bc4305e35bb9c18d5ce969f63f51

[sprang_webrtc, 2017-08-11 12:13:01]

sprang@webrtc.org changed reviewers:
+ stefan@webrtc.org

[sprang_webrtc, 2017-08-11 12:13:02]

I suggest just adding this to the default list. It will at most use ~0.5kbps and
is only active when video is flowing.
Open to discussing increasing time between timing if you think that's too high.

[stefan-webrtc, 2017-08-14 12:22:32]

On 2017/08/11 12:13:02, sprang_webrtc wrote:
> I suggest just adding this to the default list. It will at most use ~0.5kbps
and
> is only active when video is flowing.
> Open to discussing increasing time between timing if you think that's too
high.

Have we verified this with UMA by now, or is this an estimate based on some
average stream?

[sprang_webrtc, 2017-08-14 12:35:21]

On 2017/08/14 12:22:32, stefan-webrtc wrote:
> On 2017/08/11 12:13:02, sprang_webrtc wrote:
> > I suggest just adding this to the default list. It will at most use ~0.5kbps
> and
> > is only active when video is flowing.
> > Open to discussing increasing time between timing if you think that's too
> high.
> 
> Have we verified this with UMA by now, or is this an estimate based on some
> average stream?

It's based on the size of the extension and the fact the we only stamp as most
one frame per 200ms.

[sprang_webrtc, 2017-08-17 15:09:59]

ping?

[stefan-webrtc, 2017-08-21 14:09:31]

lgtm

[sprang_webrtc, 2017-08-22 11:40:59]

The CQ bit was checked by sprang@webrtc.org

[commit-bot: I haz the power, 2017-08-22 11:41:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-22 11:44:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-22 11:44:37]

Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/24160)

[sprang_webrtc, 2017-08-22 11:57:25]

The CQ bit was checked by sprang@webrtc.org

[sprang_webrtc, 2017-08-22 11:57:25]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2994893002/#ps20001 (title:
"Rebase")

[commit-bot: I haz the power, 2017-08-22 11:57:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-22 14:05:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1503403045016650,
"parent_rev": "440b6d9a0f22d9059ca330fd597dcfd0d6fc5377", "commit_rev":
"eb13f5e40048bc4305e35bb9c18d5ce969f63f51"}

[commit-bot: I haz the power, 2017-08-22 14:05:53]

Description was changed from

==========
Add video timing frames to set of default RTP header extensions

BUG=webrtc:7594
==========

to

==========
Add video timing frames to set of default RTP header extensions

BUG=webrtc:7594

Review-Url: https://codereview.webrtc.org/2994893002
Cr-Commit-Position: refs/heads/master@{#19449}
Committed:
https://chromium.googlesource.com/external/webrtc/+/eb13f5e40048bc4305e35bb9c...
==========

[commit-bot: I haz the power, 2017-08-22 14:05:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/eb13f5e40048bc4305e35bb9c...