Adding comments explaining Java createSender and setTrack methods.

Adding comments explaining Java createSender and setTrack methods.

This has been a frequent source of confusion, especially since the
method names don't match anything in the standard exactly.

BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2994733002
Cr-Commit-Position: refs/heads/master@{#19290}
Committed: https://chromium.googlesource.com/external/webrtc/+/7a24688f6fd8189db9c153c383e05368f99b093c

[Taylor Brandstetter, 2017-08-08 01:37:13]

deadbeef@webrtc.org changed reviewers:
+ sakal@webrtc.org

[Taylor Brandstetter, 2017-08-08 01:37:14]

PTAL

[sakal, 2017-08-09 05:38:27]

lgtm

You can also add "NOTRY=True" to skip the trybots since this CL only changes
comments.

https://codereview.webrtc.org/2994733002/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/PeerConnection.java (right):

https://codereview.webrtc.org/2994733002/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/PeerConnection.java:289: // This method allows
an application to cause the PeerConnection to negotiate
nit: Please use Javadoc style instead.

https://codereview.webrtc.org/2994733002/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/RtpSender.java (right):

https://codereview.webrtc.org/2994733002/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/RtpSender.java:32: // If |takeOwnership| is
true, the RtpSender takes ownership of the track
nit: Also change this to be Javadoc.

[Taylor Brandstetter, 2017-08-09 15:36:08]

Description was changed from

==========
Adding comments explaining Java createSender and setTrack methods.

This has been a frequent source of confusion, especially since the
method names don't match anything in the standard exactly.

BUG=None
==========

to

==========
Adding comments explaining Java createSender and setTrack methods.

This has been a frequent source of confusion, especially since the
method names don't match anything in the standard exactly.

BUG=None
NOTRY=True
==========

[Taylor Brandstetter, 2017-08-09 15:36:28]

https://codereview.webrtc.org/2994733002/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/PeerConnection.java (right):

https://codereview.webrtc.org/2994733002/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/PeerConnection.java:289: // This method allows
an application to cause the PeerConnection to negotiate
On 2017/08/09 05:38:27, sakal wrote:
> nit: Please use Javadoc style instead.

Done.

https://codereview.webrtc.org/2994733002/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/RtpSender.java (right):

https://codereview.webrtc.org/2994733002/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/RtpSender.java:32: // If |takeOwnership| is
true, the RtpSender takes ownership of the track
On 2017/08/09 05:38:27, sakal wrote:
> nit: Also change this to be Javadoc.

Done.

[Taylor Brandstetter, 2017-08-09 15:37:07]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-08-09 15:37:07]

The patchset sent to the CQ was uploaded after l-g-t-m from sakal@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2994733002/#ps20001 (title:
"Convert to javadoc style comments")

[commit-bot: I haz the power, 2017-08-09 15:37:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-09 15:40:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1502293027193920,
"parent_rev": "8497fdde43d920ab1f0cc90362534e5493d23abe", "commit_rev":
"7a24688f6fd8189db9c153c383e05368f99b093c"}

[commit-bot: I haz the power, 2017-08-09 15:40:18]

Description was changed from

==========
Adding comments explaining Java createSender and setTrack methods.

This has been a frequent source of confusion, especially since the
method names don't match anything in the standard exactly.

BUG=None
NOTRY=True
==========

to

==========
Adding comments explaining Java createSender and setTrack methods.

This has been a frequent source of confusion, especially since the
method names don't match anything in the standard exactly.

BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2994733002
Cr-Commit-Position: refs/heads/master@{#19290}
Committed:
https://chromium.googlesource.com/external/webrtc/+/7a24688f6fd8189db9c153c38...
==========

[commit-bot: I haz the power, 2017-08-09 15:40:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/7a24688f6fd8189db9c153c38...