Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2994403002: RTC_CHECK instead of assert in vp9_impl.cc (Closed)

Created:
3 years, 4 months ago by sprang_webrtc
Modified:
3 years, 4 months ago
Reviewers:
ilnik
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTC_CHECK instead of assert in vp9_impl.cc BUG=None Review-Url: https://codereview.webrtc.org/2994403002 Cr-Commit-Position: refs/heads/master@{#19387} Committed: https://chromium.googlesource.com/external/webrtc/+/3958ed8e6f42ba436df86e42658b2156b3296575

Patch Set 1 #

Patch Set 2 : nullptr instead of NULL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -38 lines) Patch
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 15 chunks +38 lines, -38 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sprang_webrtc
fixing some trivial style things
3 years, 4 months ago (2017-08-17 12:53:03 UTC) #2
ilnik
On 2017/08/17 12:53:03, sprang_webrtc wrote: > fixing some trivial style things Lgtm.
3 years, 4 months ago (2017-08-17 13:06:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2994403002/20001
3 years, 4 months ago (2017-08-17 15:09:28 UTC) #9
commit-bot: I haz the power
3 years, 4 months ago (2017-08-17 15:12:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/3958ed8e6f42ba436df86e426...

Powered by Google App Engine
This is Rietveld 408576698