Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2994323002: Don't boost pacing rate after pause. (Closed)

Created:
3 years, 4 months ago by sprang_webrtc
Modified:
3 years, 4 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't boost pacing rate after pause. The pacer has a mechanism to make sure all packets are sent within some time limit. This is based on the average queue time of the packets in the pacer queue. If the pacer is paused while packets are still in the queue (for instance if the underlying transport goes down temporarily), on resume all those packets might be past the time limit and thus will all be burst out onto the network in a tight loop. This CL subtracts pause time from the queue time, effectively pausing the clock for the queue while the pacer is paused, so that when we resume the pacing bitrate will be the same as when we paused. BUG=webrtc:7694 Review-Url: https://codereview.webrtc.org/2994323002 Cr-Commit-Position: refs/heads/master@{#19367} Committed: https://chromium.googlesource.com/external/webrtc/+/ddcfb9fc6a5a41b3d6fd8a2524b6a607072118d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -10 lines) Patch
M webrtc/modules/pacing/paced_sender.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 8 chunks +39 lines, -9 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sprang_webrtc
3 years, 4 months ago (2017-08-16 10:34:32 UTC) #4
philipel
lgtm
3 years, 4 months ago (2017-08-16 11:08:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2994323002/1
3 years, 4 months ago (2017-08-16 12:36:22 UTC) #9
commit-bot: I haz the power
3 years, 4 months ago (2017-08-16 12:39:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/ddcfb9fc6a5a41b3d6fd8a252...

Powered by Google App Engine
This is Rietveld 408576698