Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2994123002: Add --canary flag to gradle project test and update gradle. (Closed)

Created:
3 years, 4 months ago by sakal
Modified:
3 years, 4 months ago
Reviewers:
kthelgason
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add --canary flag to gradle project test and update gradle. This flag enables support for Android Studio 3.0 which allows us to use Java 8 features. Gradle is updated to version 4.1.0. BUG=webrtc:8084 Review-Url: https://codereview.webrtc.org/2994123002 Cr-Commit-Position: refs/heads/master@{#19319} Committed: https://chromium.googlesource.com/external/webrtc/+/42f1d6e23abfc973daa6b56f36aa8150573a3cb4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/androidtests/gradle_project_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
sakal
3 years, 4 months ago (2017-08-11 07:10:24 UTC) #4
kthelgason
Assuming this all works as you say it does, then lgtm! :D
3 years, 4 months ago (2017-08-11 07:17:07 UTC) #5
kthelgason
On 2017/08/11 07:17:07, kthelgason wrote: > Assuming this all works as you say it does, ...
3 years, 4 months ago (2017-08-11 07:17:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2994123002/1
3 years, 4 months ago (2017-08-11 08:00:33 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2017-08-11 08:03:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/42f1d6e23abfc973daa6b56f3...

Powered by Google App Engine
This is Rietveld 408576698