Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2994093002: Workaround for PacketBuffer bug. (Closed)

Created:
3 years, 4 months ago by philipel
Modified:
3 years, 4 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Workaround for PacketBuffer bug. There exist a bug in the video_coding::PacketBuffer which triggers when a frame is the same size as the buffer. A trivial workaround is to increase the start size to something big so that this never happens in practice. The bug has been fixed but we still want to test the workaround in ToT, which is why this CL exist. BUG=webrtc:8028, chromium:752886 R=stefan@webrtc.org Review-Url: https://codereview.webrtc.org/2994093002 . Cr-Commit-Position: refs/heads/master@{#19308} Committed: https://chromium.googlesource.com/external/webrtc/+/3bf97cf0602f150e05b5424735cced520aa0cfef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M webrtc/video/rtp_video_stream_receiver.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2994093002/1
3 years, 4 months ago (2017-08-10 15:35:31 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/builds/25631) android_compile_mips_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 4 months ago (2017-08-10 15:38:22 UTC) #5
stefan-webrtc
lgtm
3 years, 4 months ago (2017-08-10 15:43:34 UTC) #7
philipel
3 years, 4 months ago (2017-08-10 16:11:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3bf97cf0602f150e05b5424735cced520aa0cfef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698