Add Android Camera To Unity Plugin

Add Android Camera To Unity Plugin

The existing unity plugin (an example in webrtc codebase) does not support camera access on Android platform. This CL implements such functionality.

TBR=gyzhou@chromium.org

BUG=webrtc:8067
Review-Url: https://codereview.webrtc.org/2993273002
Cr-Commit-Position: refs/heads/master@{#19277}
Committed: https://chromium.googlesource.com/external/webrtc/+/42f96d53f3acf7a721d456b6eae872bb6f37a0a0

[qiangchen, 2017-08-08 15:58:19]

Description was changed from

==========
Add Android Camera To Unity Plugin

The existing unity plugin (an example in webrtc codebase) does not support
camera access. This CL
implements such functionality.

The instruction doc is at
https://docs.google.com/document/d/1eYro235JG-GvsDVsoHQvEd2ZLt70h01t3_FDd8R2zq8/

Bug: webrtc:8067

Nits


Nits


Move Android Specific Code Into Macro


Instruction Remove Exta Spaces


Add Instruction


Remove unnecessary file change


Test AppRTC Java


Delete unused file


Add java file


Add Direct DEPS


Remove Debug Logging


Add DEPS


Move android specific code under MACRO


Add Android Camera To Unity Plugin
==========

to

==========
Add Android Camera To Unity Plugin

The existing unity plugin (an example in webrtc codebase) does not support
camera access on Android platform. This CL implements such functionality.

Bug: webrtc:8067
==========

[qiangchen, 2017-08-08 15:58:36]

Description was changed from

==========
Add Android Camera To Unity Plugin

The existing unity plugin (an example in webrtc codebase) does not support
camera access on Android platform. This CL implements such functionality.

Bug: webrtc:8067
==========

to

==========
Add Android Camera To Unity Plugin

The existing unity plugin (an example in webrtc codebase) does not support
camera access on Android platform. This CL implements such functionality.

Bug=webrtc:8067
==========

[qiangchen, 2017-08-08 15:59:11]

qiangchen@chromium.org changed reviewers:
+ gyzhou@chromium.org

[qiangchen, 2017-08-08 16:00:34]

The CQ bit was checked by qiangchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-08 16:00:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-08 16:05:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-08 16:05:56]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/19930)

[qiangchen, 2017-08-08 16:35:03]

Description was changed from

==========
Add Android Camera To Unity Plugin

The existing unity plugin (an example in webrtc codebase) does not support
camera access on Android platform. This CL implements such functionality.

Bug=webrtc:8067
==========

to

==========
Add Android Camera To Unity Plugin

The existing unity plugin (an example in webrtc codebase) does not support
camera access on Android platform. This CL implements such functionality.

TBR=gyzhou@chromium.org
NOPRESUBMIT=true

Bug=webrtc:8067
==========

[GeorgeZ, 2017-08-08 22:01:26]

On 2017/08/08 16:35:03, qiangchen wrote:
> Description was changed from
> 
> ==========
> Add Android Camera To Unity Plugin
> 
> The existing unity plugin (an example in webrtc codebase) does not support
> camera access on Android platform. This CL implements such functionality.
> 
> Bug=webrtc:8067
> ==========
> 
> to
> 
> ==========
> Add Android Camera To Unity Plugin
> 
> The existing unity plugin (an example in webrtc codebase) does not support
> camera access on Android platform. This CL implements such functionality.
> 
> mailto:TBR=gyzhou@chromium.org
> NOPRESUBMIT=true
> 
> Bug=webrtc:8067
> ==========

LGTM

[GeorgeZ, 2017-08-08 22:01:27]

On 2017/08/08 16:35:03, qiangchen wrote:
> Description was changed from
> 
> ==========
> Add Android Camera To Unity Plugin
> 
> The existing unity plugin (an example in webrtc codebase) does not support
> camera access on Android platform. This CL implements such functionality.
> 
> Bug=webrtc:8067
> ==========
> 
> to
> 
> ==========
> Add Android Camera To Unity Plugin
> 
> The existing unity plugin (an example in webrtc codebase) does not support
> camera access on Android platform. This CL implements such functionality.
> 
> mailto:TBR=gyzhou@chromium.org
> NOPRESUBMIT=true
> 
> Bug=webrtc:8067
> ==========

LGTM

[qiangchen, 2017-08-08 22:01:54]

Description was changed from

==========
Add Android Camera To Unity Plugin

The existing unity plugin (an example in webrtc codebase) does not support
camera access on Android platform. This CL implements such functionality.

TBR=gyzhou@chromium.org
NOPRESUBMIT=true

Bug=webrtc:8067
==========

to

==========
Add Android Camera To Unity Plugin

The existing unity plugin (an example in webrtc codebase) does not support
camera access on Android platform. This CL implements such functionality.

TBR=gyzhou@chromium.org

Bug=webrtc:8067
==========

[qiangchen, 2017-08-08 22:01:58]

The CQ bit was checked by qiangchen@chromium.org

[commit-bot: I haz the power, 2017-08-08 22:02:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[qiangchen, 2017-08-08 22:06:05]

Description was changed from

==========
Add Android Camera To Unity Plugin

The existing unity plugin (an example in webrtc codebase) does not support
camera access on Android platform. This CL implements such functionality.

TBR=gyzhou@chromium.org

Bug=webrtc:8067
==========

to

==========
Add Android Camera To Unity Plugin

The existing unity plugin (an example in webrtc codebase) does not support
camera access on Android platform. This CL implements such functionality.

TBR=gyzhou@chromium.org

BUG=webrtc:8067
==========

[commit-bot: I haz the power, 2017-08-08 22:07:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-08 22:07:38]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/19940)

[qiangchen, 2017-08-08 22:35:19]

The CQ bit was checked by qiangchen@chromium.org

[qiangchen, 2017-08-08 22:35:20]

The patchset sent to the CQ was uploaded after l-g-t-m from gyzhou@chromium.org
Link to the patchset: https://codereview.webrtc.org/2993273002/#ps20001 (title:
"Presubmit Fix")

[commit-bot: I haz the power, 2017-08-08 22:35:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-09 00:08:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1502231719617100,
"parent_rev": "b2b803cb74168d1a94a072534d103cab6d6dd199", "commit_rev":
"42f96d53f3acf7a721d456b6eae872bb6f37a0a0"}

[commit-bot: I haz the power, 2017-08-09 00:08:11]

Description was changed from

==========
Add Android Camera To Unity Plugin

The existing unity plugin (an example in webrtc codebase) does not support
camera access on Android platform. This CL implements such functionality.

TBR=gyzhou@chromium.org

BUG=webrtc:8067
==========

to

==========
Add Android Camera To Unity Plugin

The existing unity plugin (an example in webrtc codebase) does not support
camera access on Android platform. This CL implements such functionality.

TBR=gyzhou@chromium.org

BUG=webrtc:8067

Review-Url: https://codereview.webrtc.org/2993273002
Cr-Commit-Position: refs/heads/master@{#19277}
Committed:
https://chromium.googlesource.com/external/webrtc/+/42f96d53f3acf7a721d456b6e...
==========

[commit-bot: I haz the power, 2017-08-09 00:08:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/42f96d53f3acf7a721d456b6e...