Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2993173003:
Ignore invalid mouse cursor image (Closed)
DescriptionIgnore invalid mouse cursor image
A crash has been randomly detected across different versions. The NSImage
crashes the binary in its lockFocusFlipped() function. The suspicious issue is
that NSCursor::image() returns an invalid NSImage.
BUG=chromium:752036
Review-Url: https://codereview.webrtc.org/2993173003
Cr-Commit-Position: refs/heads/master@{#19273}
Committed: https://chromium.googlesource.com/external/webrtc/+/f50fda9534563885ab080ae18c2540a0f5b930bc
Patch Set 1 #
Total comments: 2
Patch Set 2 : Resolve review comments #Messages
Total messages: 18 (12 generated)
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
zijiehe@chromium.org changed reviewers: + jamiewalch@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.webrtc.org/2993173003/diff/1/webrtc/modules/desktop_captur... File webrtc/modules/desktop_capture/mouse_cursor_monitor_mac.mm (right): https://codereview.webrtc.org/2993173003/diff/1/webrtc/modules/desktop_captur... webrtc/modules/desktop_capture/mouse_cursor_monitor_mac.mm:259: if (!nsimage.isValid) { According to https://developer.apple.com/documentation/appkit/nscursor/1527062-image?langu..., this will return nil if invalid. I'm not sure if isValid returns false if you call it on nil, or if it will still crash, but it seems like a nil check might be a better option here.
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
https://codereview.webrtc.org/2993173003/diff/1/webrtc/modules/desktop_captur... File webrtc/modules/desktop_capture/mouse_cursor_monitor_mac.mm (right): https://codereview.webrtc.org/2993173003/diff/1/webrtc/modules/desktop_captur... webrtc/modules/desktop_capture/mouse_cursor_monitor_mac.mm:259: if (!nsimage.isValid) { On 2017/08/07 21:49:34, Jamie wrote: > According to > https://developer.apple.com/documentation/appkit/nscursor/1527062-image?langu..., > this will return nil if invalid. I'm not sure if isValid returns false if you > call it on nil, or if it will still crash, but it seems like a nil check might > be a better option here. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1502213529627250,
"parent_rev": "1921bea4de02604e7c08e8a15298212d911dd15d", "commit_rev":
"f50fda9534563885ab080ae18c2540a0f5b930bc"}
Message was sent while issue was closed.
Description was changed from ========== Ignore invalid mouse cursor image A crash has been randomly detected across different versions. The NSImage crashes the binary in its lockFocusFlipped() function. The suspicious issue is that NSCursor::image() returns an invalid NSImage. BUG=chromium:752036 ========== to ========== Ignore invalid mouse cursor image A crash has been randomly detected across different versions. The NSImage crashes the binary in its lockFocusFlipped() function. The suspicious issue is that NSCursor::image() returns an invalid NSImage. BUG=chromium:752036 Review-Url: https://codereview.webrtc.org/2993173003 Cr-Commit-Position: refs/heads/master@{#19273} Committed: https://chromium.googlesource.com/external/webrtc/+/f50fda9534563885ab080ae18... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/f50fda9534563885ab080ae18... |
