Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2992953002:
Decoupling video_capture_internal_imlp from Obj-C code. (Closed)
|
Created:
3 years, 4 months ago by mbonadei Modified:
3 years, 3 months ago Reviewers:
kjellander_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, perkj_webrtc, mflodman, sdk-team_agora.io Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDecoupling video_capture_internal_imlp from Obj-C code
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).
BUG=webrtc:7743
NOTRY=True
Review-Url: https://codereview.webrtc.org/2992953002
Cr-Commit-Position: refs/heads/master@{#19662}
Committed: https://chromium.googlesource.com/external/webrtc/+/054b10882001974e419a808eea995f6d38a33ba3
Patch Set 1 #Patch Set 2 : Generate objc_video_capture_internal_impl only for ios/mac #
Total comments: 3
Patch Set 3 : Renaming and adding private visibility #Patch Set 4 : Adding comments to explain the noop.{cc,mm} trick #Patch Set 5 : Switching to rtc_source_set to remove noop.cc #Messages
Total messages: 22 (13 generated)
mbonadei@webrtc.org changed reviewers: + kjellander@webrtc.org
https://codereview.webrtc.org/2992953002/diff/20001/webrtc/modules/video_capt... File webrtc/modules/video_capture/BUILD.gn (right): https://codereview.webrtc.org/2992953002/diff/20001/webrtc/modules/video_capt... webrtc/modules/video_capture/BUILD.gn:90: rtc_static_library("objc_video_capture_internal_impl") { video_capture_internal_impl_objc https://codereview.webrtc.org/2992953002/diff/20001/webrtc/modules/video_capt... File webrtc/modules/video_capture/objc/noop.cc (right): https://codereview.webrtc.org/2992953002/diff/20001/webrtc/modules/video_capt... webrtc/modules/video_capture/objc/noop.cc:15: // "objc_video_capture_internal_impl". Update this target name reference too. I didn't realize the file could be completely empty in order to satisfy the compiler. Good to know!
PTAL. https://codereview.webrtc.org/2992953002/diff/20001/webrtc/modules/video_capt... File webrtc/modules/video_capture/BUILD.gn (right): https://codereview.webrtc.org/2992953002/diff/20001/webrtc/modules/video_capt... webrtc/modules/video_capture/BUILD.gn:90: rtc_static_library("objc_video_capture_internal_impl") { On 2017/08/14 07:00:39, kjellander_webrtc wrote: > video_capture_internal_impl_objc Done + added private visibility.
lgtm
Description was changed from ========== Decoupling video_capture_internal_imlp from Obj-C code. This is not needed in order to fix webrtc:7743 but it can help to keep the pre-submit check simple. BUG=webrtc:7743 ========== to ========== The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 ==========
Description was changed from ========== The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 ========== to ========== Decoupling video_capture_internal_imlp from Obj-C code The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 ==========
The CQ bit was checked by mbonadei@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from kjellander@webrtc.org Link to the patchset: https://codereview.webrtc.org/2992953002/#ps60001 (title: "Adding comments to explain the noop.{cc,mm} trick")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/21055)
On 2017/08/31 13:41:36, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > presubmit on master.tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/21055) My bad, I forgot to ask for an LGTM to a directory owner.
mbonadei@webrtc.org changed reviewers: + mflodman@webrtc.org
mbonadei@webrtc.org changed reviewers: - mflodman@webrtc.org
Description was changed from ========== Decoupling video_capture_internal_imlp from Obj-C code The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 ========== to ========== Decoupling video_capture_internal_imlp from Obj-C code The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 NOTRY=True ==========
The CQ bit was checked by mbonadei@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from kjellander@webrtc.org Link to the patchset: https://codereview.webrtc.org/2992953002/#ps80001 (title: "Switching to rtc_source_set to remove noop.cc")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1504533149768660,
"parent_rev": "a0a5b98937de0f0bf90e17011d2cbc8c632cb409", "commit_rev":
"054b10882001974e419a808eea995f6d38a33ba3"}
Message was sent while issue was closed.
Description was changed from ========== Decoupling video_capture_internal_imlp from Obj-C code The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 NOTRY=True ========== to ========== Decoupling video_capture_internal_imlp from Obj-C code The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 NOTRY=True Review-Url: https://codereview.webrtc.org/2992953002 Cr-Commit-Position: refs/heads/master@{#19662} Committed: https://chromium.googlesource.com/external/webrtc/+/054b10882001974e419a808ee... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/external/webrtc/+/054b10882001974e419a808ee... |
