Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2992943002: ObjC: Support non-native frames in encoder (Closed)

Created:
3 years, 4 months ago by magjed_webrtc
Modified:
3 years, 4 months ago
Reviewers:
andersc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

ObjC: Support non-native frames in encoder Frames might be non-native, i.e. normal I420 frames, and we should handle that in the encoder. BUG=webrtc:7785, webrtc:7924 Review-Url: https://codereview.webrtc.org/2992943002 Cr-Commit-Position: refs/heads/master@{#19245} Committed: https://chromium.googlesource.com/external/webrtc/+/512bee3dee4afd960e378f951570984e171782b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -19 lines) Patch
M webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm View 7 chunks +25 lines, -19 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
magjed_webrtc
Anders - please take a look.
3 years, 4 months ago (2017-08-03 12:34:41 UTC) #7
andersc
lgtm Looks like basically the same solution that is in the "Implement H264 codec in ...
3 years, 4 months ago (2017-08-03 17:02:10 UTC) #8
magjed_webrtc
On 2017/08/03 17:02:10, andersc wrote: > lgtm > > Looks like basically the same solution ...
3 years, 4 months ago (2017-08-04 09:01:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2992943002/1
3 years, 4 months ago (2017-08-04 09:02:29 UTC) #11
commit-bot: I haz the power
3 years, 4 months ago (2017-08-04 09:05:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/512bee3dee4afd960e378f951...

Powered by Google App Engine
This is Rietveld 408576698