Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2992823002:
Override C++ standard to -std=gnu++11 (Closed)
|
Created:
3 years, 4 months ago by oprypin_webrtc Modified:
3 years, 4 months ago CC:
webrtc-reviews_webrtc.org Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionOverride C++ standard to -std=gnu++11
Chromium switched to C++14 but WebRTC does not want to follow suit.
This enables the override added in
https://chromium-review.googlesource.com/c/596870
BUG=chromium:750683
NOTRY=True
Review-Url: https://codereview.webrtc.org/2992823002
Cr-Commit-Position: refs/heads/master@{#19207}
Committed: https://chromium.googlesource.com/external/webrtc/+/28104eb31b1ee531eac9e63e96a359f42834cd64
Patch Set 1 #Messages
Total messages: 19 (10 generated)
Description was changed from ========== Override C++ standard to -std=gnu++11 BUG=chromium:750683 Chromium switched to C++14 but WebRTC does not want to follow suit. This enables the override added in https://chromium-review.googlesource.com/c/596870 ========== to ========== Override C++ standard to -std=gnu++11 BUG=chromium:750683 Chromium switched to C++14 but WebRTC does not want to follow suit. This enables the override added in https://chromium-review.googlesource.com/c/596870 ==========
oprypin@webrtc.org changed reviewers: + ehmaldonado@webrtc.org, kwiberg@webrtc.org
On 2017/08/01 20:35:02, oprypin_webrtc wrote: I'd describe the flag as something like "Use c++11 instead of c++14 for GCC builds." LGTM anyway.
On 2017/08/01 20:44:01, ehmaldonado_webrtc wrote: > On 2017/08/01 20:35:02, oprypin_webrtc wrote: > > I'd describe the flag as something like "Use c++11 instead of c++14 for GCC > builds." > LGTM anyway. C++11 will be used for all builds.
The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Not submitting because it needs OWNERS review still
On 2017/08/01 20:49:29, oprypin_webrtc wrote: > On 2017/08/01 20:44:01, ehmaldonado_webrtc wrote: > > On 2017/08/01 20:35:02, oprypin_webrtc wrote: > > > > I'd describe the flag as something like "Use c++11 instead of c++14 for GCC > > builds." > > LGTM anyway. > > C++11 will be used for all builds. Right, true.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
lgtm
Description was changed from ========== Override C++ standard to -std=gnu++11 BUG=chromium:750683 Chromium switched to C++14 but WebRTC does not want to follow suit. This enables the override added in https://chromium-review.googlesource.com/c/596870 ========== to ========== Override C++ standard to -std=gnu++11 Chromium switched to C++14 but WebRTC does not want to follow suit. This enables the override added in https://chromium-review.googlesource.com/c/596870 BUG=chromium:750683 NOTRY=True ==========
Added NOTRY because this only works when https://codereview.webrtc.org/2991183003/ lands
The CQ bit was checked by oprypin@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1501662220861460, "parent_rev":
"8339e1a7aae74f1b49a3f1d3cae8cef190805ef7", "commit_rev":
"28104eb31b1ee531eac9e63e96a359f42834cd64"}
Message was sent while issue was closed.
Description was changed from ========== Override C++ standard to -std=gnu++11 Chromium switched to C++14 but WebRTC does not want to follow suit. This enables the override added in https://chromium-review.googlesource.com/c/596870 BUG=chromium:750683 NOTRY=True ========== to ========== Override C++ standard to -std=gnu++11 Chromium switched to C++14 but WebRTC does not want to follow suit. This enables the override added in https://chromium-review.googlesource.com/c/596870 BUG=chromium:750683 NOTRY=True Review-Url: https://codereview.webrtc.org/2992823002 Cr-Commit-Position: refs/heads/master@{#19207} Committed: https://chromium.googlesource.com/external/webrtc/+/28104eb31b1ee531eac9e63e9... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/28104eb31b1ee531eac9e63e9... |
