Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 2991643002: Creating a more generic memcheck suppression (Closed)

Created:
3 years, 5 months ago by mbonadei
Modified:
3 years, 5 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Creating a more generic memcheck suppression Chromium roll into WebRTC is failing because of a memcheck error. The tool suggests to add this suppression: { <insert_a_suppression_name_here> Memcheck:Uninitialized fun:vfprintf fun:vsnprintf fun:snprintf fun:_ZN7testing9internal220PrintBytesInObjectToEPKhmPSo fun:_ZN7testing8internal14Default... fun:_ZN7testing8internal20MatchPrint... fun:_ZNK7testing8internal29Predicate... } This CL tries to remove some duplication using a more generic pattern. BUG=webrtc:6773 NOTRY=True Review-Url: https://codereview.webrtc.org/2991643002 Cr-Commit-Position: refs/heads/master@{#19132} Committed: https://chromium.googlesource.com/external/webrtc/+/d5e3d0f958aa63a93f2e04b57f0d62c2f1a051d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M tools_webrtc/valgrind/memcheck/suppressions.txt View 1 chunk +1 line, -24 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
mbonadei
3 years, 5 months ago (2017-07-25 13:14:15 UTC) #3
kjellander_webrtc
lgtm
3 years, 5 months ago (2017-07-25 14:22:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2991643002/1
3 years, 5 months ago (2017-07-25 14:26:52 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-07-25 14:30:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d5e3d0f958aa63a93f2e04b57...

Powered by Google App Engine
This is Rietveld 408576698