Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h

Issue 2991623002: Add SetReportBlocks to rtcp Sender/Receive Report classes. (Closed)
Patch Set: More comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h
index 85ab8ebd347acec775fbcfd2b194572b3f9689d0..1b08f6404cea1d31c80d505c89eecdf1ce733985 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h
@@ -24,6 +24,8 @@ class CommonHeader;
class ReceiverReport : public RtcpPacket {
public:
static constexpr uint8_t kPacketType = 201;
+ static constexpr size_t kMaxNumberOfReportBlocks = 0x1f;
eladalon 2017/07/25 13:26:09 (Not actionable.) Does this correspond to a field
danilchap 2017/07/25 13:39:00 yes, there are 5 bits to store number of report bl
+
ReceiverReport();
~ReceiverReport() override;
@@ -32,6 +34,7 @@ class ReceiverReport : public RtcpPacket {
void SetSenderSsrc(uint32_t ssrc) { sender_ssrc_ = ssrc; }
bool AddReportBlock(const ReportBlock& block);
+ bool SetReportBlocks(std::vector<ReportBlock> blocks);
uint32_t sender_ssrc() const { return sender_ssrc_; }
const std::vector<ReportBlock>& report_blocks() const {
@@ -47,7 +50,6 @@ class ReceiverReport : public RtcpPacket {
private:
static const size_t kRrBaseLength = 4;
- static const size_t kMaxNumberOfReportBlocks = 0x1F;
uint32_t sender_ssrc_;
std::vector<ReportBlock> report_blocks_;

Powered by Google App Engine
This is Rietveld 408576698