Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h

Issue 2991623002: Add SetReportBlocks to rtcp Sender/Receive Report classes. (Closed)
Patch Set: More comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_RECEIVER_REPORT_H_ 11 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_RECEIVER_REPORT_H_
12 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_RECEIVER_REPORT_H_ 12 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_RECEIVER_REPORT_H_
13 13
14 #include <vector> 14 #include <vector>
15 15
16 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet.h" 16 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet.h"
17 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block.h" 17 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block.h"
18 #include "webrtc/rtc_base/basictypes.h" 18 #include "webrtc/rtc_base/basictypes.h"
19 19
20 namespace webrtc { 20 namespace webrtc {
21 namespace rtcp { 21 namespace rtcp {
22 class CommonHeader; 22 class CommonHeader;
23 23
24 class ReceiverReport : public RtcpPacket { 24 class ReceiverReport : public RtcpPacket {
25 public: 25 public:
26 static constexpr uint8_t kPacketType = 201; 26 static constexpr uint8_t kPacketType = 201;
27 static constexpr size_t kMaxNumberOfReportBlocks = 0x1f;
eladalon 2017/07/25 13:26:09 (Not actionable.) Does this correspond to a field
danilchap 2017/07/25 13:39:00 yes, there are 5 bits to store number of report bl
28
27 ReceiverReport(); 29 ReceiverReport();
28 ~ReceiverReport() override; 30 ~ReceiverReport() override;
29 31
30 // Parse assumes header is already parsed and validated. 32 // Parse assumes header is already parsed and validated.
31 bool Parse(const CommonHeader& packet); 33 bool Parse(const CommonHeader& packet);
32 34
33 void SetSenderSsrc(uint32_t ssrc) { sender_ssrc_ = ssrc; } 35 void SetSenderSsrc(uint32_t ssrc) { sender_ssrc_ = ssrc; }
34 bool AddReportBlock(const ReportBlock& block); 36 bool AddReportBlock(const ReportBlock& block);
37 bool SetReportBlocks(std::vector<ReportBlock> blocks);
35 38
36 uint32_t sender_ssrc() const { return sender_ssrc_; } 39 uint32_t sender_ssrc() const { return sender_ssrc_; }
37 const std::vector<ReportBlock>& report_blocks() const { 40 const std::vector<ReportBlock>& report_blocks() const {
38 return report_blocks_; 41 return report_blocks_;
39 } 42 }
40 43
41 size_t BlockLength() const override; 44 size_t BlockLength() const override;
42 45
43 bool Create(uint8_t* packet, 46 bool Create(uint8_t* packet,
44 size_t* index, 47 size_t* index,
45 size_t max_length, 48 size_t max_length,
46 RtcpPacket::PacketReadyCallback* callback) const override; 49 RtcpPacket::PacketReadyCallback* callback) const override;
47 50
48 private: 51 private:
49 static const size_t kRrBaseLength = 4; 52 static const size_t kRrBaseLength = 4;
50 static const size_t kMaxNumberOfReportBlocks = 0x1F;
51 53
52 uint32_t sender_ssrc_; 54 uint32_t sender_ssrc_;
53 std::vector<ReportBlock> report_blocks_; 55 std::vector<ReportBlock> report_blocks_;
54 }; 56 };
55 57
56 } // namespace rtcp 58 } // namespace rtcp
57 } // namespace webrtc 59 } // namespace webrtc
58 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_RECEIVER_REPORT_H_ 60 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_RECEIVER_REPORT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698