Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 2991453002: Restore UriReferencedElement and its uri/uriOffset/uriEnd properties. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Restore UriReferencedElement and its uri/uriOffset/uriEnd properties. This is a partial rollback of bdd69ccd6c330e4755a447964a1f1021be034f75, it restores APIs and implementations, but does not restore its usages in analyzer or analysis_server. Should be enough to make clients temporary OK, but also keeps resynthesizing from Kernel working. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ce4d7b18912b6c122d6f4e1bf7ada561dffde670

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -21 lines) Patch
M pkg/analyzer/lib/dart/element/element.dart View 4 chunks +28 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/builder.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 9 chunks +189 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/handle.dart View 3 chunks +27 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-07-21 22:03:46 UTC) #1
Brian Wilkerson
lgtm
3 years, 5 months ago (2017-07-21 22:06:04 UTC) #2
scheglov
3 years, 5 months ago (2017-07-22 00:00:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ce4d7b18912b6c122d6f4e1bf7ada561dffde670 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698