Decoupling test targets from Obj-C code

The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).

We have moved .mm files out of test_support and fileutils (into test_support_objc
and fileutils_objc).

To achieve the goal for run_test and test_renderer (in the next part of the phrase
X is run_test or test_renderer) we have created 2 targets (X_objc and X_generic)
and X will act as a proxy between these targets (this way we can avoid a circular
dependency between X_generic and X_objc).

BUG=webrtc:7743
Review-Url: https://codereview.webrtc.org/2991323003
Cr-Commit-Position: refs/heads/master@{#19479}
Committed: https://chromium.googlesource.com/external/webrtc/+/cd95a4ec76cc607886c21144b451c1b8e871013a

[mbonadei, 2017-08-11 12:10:45]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-08-14 06:56:46]

https://codereview.webrtc.org/2991323003/diff/60001/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2991323003/diff/60001/webrtc/test/BUILD.gn#newc...
webrtc/test/BUILD.gn:111: rtc_source_set("objc_test_support") {
test_support_objc

https://codereview.webrtc.org/2991323003/diff/60001/webrtc/test/BUILD.gn#newc...
webrtc/test/BUILD.gn:111: rtc_source_set("objc_test_support") {
I realized for targets like this we probably want to have visibility = [ ":*" ]
to limit their visibility to the same BUILD.gn file. Applies to all the CLs
similar to this.

[mbonadei, 2017-08-15 13:43:14]

PTAL.

https://codereview.webrtc.org/2991323003/diff/60001/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2991323003/diff/60001/webrtc/test/BUILD.gn#newc...
webrtc/test/BUILD.gn:111: rtc_source_set("objc_test_support") {
On 2017/08/14 06:56:46, kjellander_webrtc wrote:
> test_support_objc

Done.

https://codereview.webrtc.org/2991323003/diff/60001/webrtc/test/BUILD.gn#newc...
webrtc/test/BUILD.gn:111: rtc_source_set("objc_test_support") {
On 2017/08/14 06:56:45, kjellander_webrtc wrote:
> I realized for targets like this we probably want to have visibility = [ ":*"
]
> to limit their visibility to the same BUILD.gn file. Applies to all the CLs
> similar to this.

Done.

[kjellander_webrtc, 2017-08-15 14:14:18]

lgtm with my comment addressed.

https://codereview.webrtc.org/2991323003/diff/100001/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2991323003/diff/100001/webrtc/test/BUILD.gn#new...
webrtc/test/BUILD.gn:612: libs = []
Add
visibility = [ ":*" ]

[mbonadei, 2017-08-15 14:25:16]

https://codereview.webrtc.org/2991323003/diff/100001/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2991323003/diff/100001/webrtc/test/BUILD.gn#new...
webrtc/test/BUILD.gn:612: libs = []
On 2017/08/15 14:14:18, kjellander_webrtc wrote:
> Add
> visibility = [ ":*" ]

Done.

[mbonadei, 2017-08-16 14:37:00]

Description was changed from

==========
Decoupling test_support from Obj-C code

BUG=webrtc:7743
==========

to

==========
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).

We have moved .mm files out of test_support and fileutils (into
test_support_objc
and fileutils_objc).

To achieve the goal for run_test and test_renderer (in the next part of the
phrase
X is run_test or test_renderer) we have created 2 targets (X_objc and X_generic)
and X will act as a proxy between these targets (this way we can avoid a
circular
dependency between X_generic and X_objc).

BUG=webrtc:7743
==========

[mbonadei, 2017-08-22 12:21:30]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2017-08-22 12:21:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2991323003/#ps120001 (title:
"Adding private visibility to test_renderer_generic")

[commit-bot: I haz the power, 2017-08-22 12:21:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-22 13:11:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-22 13:11:15]

Try jobs failed on following builders:
  android_compile_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg...)

[mbonadei, 2017-08-23 12:45:13]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2017-08-23 12:45:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2991323003/#ps140001 (title:
"rebasing")

[commit-bot: I haz the power, 2017-08-23 12:45:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-23 12:48:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-23 12:48:46]

Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/24221)

[mbonadei, 2017-08-23 13:27:16]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2017-08-23 13:27:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2991323003/#ps160001 (title:
"Fixing BUILD.gn file after wrong merge")

[commit-bot: I haz the power, 2017-08-23 13:27:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-23 14:42:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-23 14:42:19]

Try jobs failed on following builders:
  android_compile_mips_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_mips_db...)

[kjellander_webrtc, 2017-08-24 04:22:05]

On 2017/08/23 14:42:19, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_compile_mips_dbg on master.tryserver.webrtc (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_mips_db...)

This is https://bugs.chromium.org/p/chromium/issues/detail?id=758222
I retried that bot for you.

[mbonadei, 2017-08-24 06:40:23]

> This is https://bugs.chromium.org/p/chromium/issues/detail?id=758222
> I retried that bot for you.

Thank you!

[mbonadei, 2017-08-24 06:51:11]

The CQ bit was checked by mbonadei@webrtc.org

[commit-bot: I haz the power, 2017-08-24 06:51:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-24 06:55:55]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1503557471666140,
"parent_rev": "ca6d3b60b521184a9c641162cf3dfad2dd0ff9e9", "commit_rev":
"cd95a4ec76cc607886c21144b451c1b8e871013a"}

[commit-bot: I haz the power, 2017-08-24 06:56:00]

Description was changed from

==========
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).

We have moved .mm files out of test_support and fileutils (into
test_support_objc
and fileutils_objc).

To achieve the goal for run_test and test_renderer (in the next part of the
phrase
X is run_test or test_renderer) we have created 2 targets (X_objc and X_generic)
and X will act as a proxy between these targets (this way we can avoid a
circular
dependency between X_generic and X_objc).

BUG=webrtc:7743
==========

to

==========
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).

We have moved .mm files out of test_support and fileutils (into
test_support_objc
and fileutils_objc).

To achieve the goal for run_test and test_renderer (in the next part of the
phrase
X is run_test or test_renderer) we have created 2 targets (X_objc and X_generic)
and X will act as a proxy between these targets (this way we can avoid a
circular
dependency between X_generic and X_objc).

BUG=webrtc:7743

Review-Url: https://codereview.webrtc.org/2991323003
Cr-Commit-Position: refs/heads/master@{#19479}
Committed:
https://chromium.googlesource.com/external/webrtc/+/cd95a4ec76cc607886c21144b...
==========

[commit-bot: I haz the power, 2017-08-24 06:56:02]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/external/webrtc/+/cd95a4ec76cc607886c21144b...