Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2991093002: Remove PacketRouterTest fixture (Closed)

Created:
3 years, 4 months ago by eladalon
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove PacketRouterTest fixture Remove the mostly-unused fixture PacketRouterTest. BUG=None Review-Url: https://codereview.webrtc.org/2991093002 Cr-Commit-Position: refs/heads/master@{#19203} Committed: https://chromium.googlesource.com/external/webrtc/+/b1338fec81b8eea646c114f5fd555a94d85abb4e

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -57 lines) Patch
M webrtc/modules/pacing/packet_router_unittest.cc View 1 12 chunks +65 lines, -57 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
eladalon
PTAL
3 years, 4 months ago (2017-07-31 14:15:36 UTC) #2
danilchap
lgtm https://codereview.webrtc.org/2991093002/diff/1/webrtc/modules/pacing/packet_router_unittest.cc File webrtc/modules/pacing/packet_router_unittest.cc (right): https://codereview.webrtc.org/2991093002/diff/1/webrtc/modules/pacing/packet_router_unittest.cc#newcode36 webrtc/modules/pacing/packet_router_unittest.cc:36: } // namespace since you've added an unnamed ...
3 years, 4 months ago (2017-07-31 14:18:15 UTC) #3
eladalon
Stefan, this needs an owner-lgtm.
3 years, 4 months ago (2017-07-31 14:31:35 UTC) #5
stefan-webrtc
rs-lgtm
3 years, 4 months ago (2017-07-31 14:32:34 UTC) #6
eladalon
https://codereview.webrtc.org/2991093002/diff/1/webrtc/modules/pacing/packet_router_unittest.cc File webrtc/modules/pacing/packet_router_unittest.cc (right): https://codereview.webrtc.org/2991093002/diff/1/webrtc/modules/pacing/packet_router_unittest.cc#newcode36 webrtc/modules/pacing/packet_router_unittest.cc:36: } // namespace On 2017/07/31 14:18:15, danilchap wrote: > ...
3 years, 4 months ago (2017-07-31 14:33:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2991093002/40001
3 years, 4 months ago (2017-08-01 15:46:27 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2017-08-01 16:36:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/b1338fec81b8eea646c114f5f...

Powered by Google App Engine
This is Rietveld 408576698