Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 2990683002: Add PeerConnectionObserver::OnRemoveTrack callback.

Created:
2 years, 5 months ago by korniltsev
Modified:
2 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add PeerConnectionObserver::OnRemoveTrack callback. BUG=None

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -7 lines) Patch
M webrtc/api/peerconnectioninterface.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/pc/peerconnection.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/pc/peerconnection.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M webrtc/pc/peerconnectioninterface_unittest.cc View 5 chunks +34 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
korniltsev
It looks like there is no way to find that the remote track is removed. ...
2 years, 5 months ago (2017-07-25 22:29:20 UTC) #3
Taylor Brandstetter
Since there isn't a direct analog to this in the spec, and this is still ...
2 years, 5 months ago (2017-07-25 23:19:46 UTC) #4
korniltsev
Thank you for suggestion. This will work. Just to clarify. I need this events in ...
2 years, 5 months ago (2017-07-26 07:26:58 UTC) #5
Taylor Brandstetter
2 years, 5 months ago (2017-07-26 18:02:55 UTC) #6
On 2017/07/26 07:26:58, korniltsev wrote:
> Thank you for suggestion. This will work.
> Just to clarify. I need this events in jni and objc, so I can stop/start
> rendering remote track when it is removed/added.
> If I implement OnRemoveTrack callback in jni and objc with a
> MediaStreamObserver, will you be able to review and merge it to upstream or we
> should wait for spec approval anyway?  
> Thanks.

The Java and Objective-C "MediaStream" objects definitely *should* be kept in
sync with the C++ objects, meaning if a track is removed from a C++ MediaStream
it should disappear from the Java MediaStream as well. And there should be a
similar observer interface for the application to listen for modifications.

It's been something I've wanted to fix for a long time, but it hasn't been a top
priority so I haven't had a chance to do it. If you want to do this, go ahead,
I'd be grateful.

Here's a bug to reference:
https://bugs.chromium.org/p/webrtc/issues/detail?id=5677

Powered by Google App Engine
This is Rietveld 408576698