Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2990493002: Skip gap blocks early to avoid stdout flooding in verbose mode, and (Closed)

Created:
3 years, 5 months ago by 0vercl0k
Modified:
3 years, 4 months ago
Reviewers:
chrisha
CC:
syzygy-changes_googlegroups.com
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

Skip gap blocks early to avoid stdout flooding in verbose mode, and instrumentation percentage bias. Also fix the instrumenter help menu. BUG= R=chrisha@chromium.org Review-Url: https://codereview.chromium.org/2990493002 Committed: https://github.com/google/syzygy/commit/41435390921310376635874bc736fef5c68f4ec7

Patch Set 1 #

Patch Set 2 : Better the comment layout. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M syzygy/instrument/instrument_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M syzygy/instrument/transforms/afl_transform.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
0vercl0k
Friendly ping Chris :). Cheers
3 years, 4 months ago (2017-08-10 04:04:00 UTC) #1
chrisha
lgtm!
3 years, 4 months ago (2017-08-14 14:52:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2990493002/20001
3 years, 4 months ago (2017-08-14 17:28:08 UTC) #8
commit-bot: I haz the power
3 years, 4 months ago (2017-08-14 17:28:16 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/google/syzygy/commit/41435390921310376635874bc736fef5c68f4ec7

Powered by Google App Engine
This is Rietveld 408576698