Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2990253002: ObjC: Remove RTCVideoFrame.nativeHandle (Closed)

Created:
3 years, 4 months ago by magjed_webrtc
Modified:
3 years, 4 months ago
Reviewers:
andersc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

ObjC: Remove RTCVideoFrame.nativeHandle Access to a native buffer should be through RTCVideoFrame.buffer instead. BUG=webrtc:7785 Review-Url: https://codereview.webrtc.org/2990253002 Cr-Commit-Position: refs/heads/master@{#19430} Committed: https://chromium.googlesource.com/external/webrtc/+/b0215daeb5ad6b686abb300fd5b998acd2e0ba98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoFrame.mm View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoFrame.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
magjed_webrtc
Anders - please take a look.
3 years, 4 months ago (2017-08-04 12:09:07 UTC) #7
andersc
lgtm
3 years, 4 months ago (2017-08-04 17:01:51 UTC) #8
andersc
lgtm
3 years, 4 months ago (2017-08-04 17:01:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2990253002/1
3 years, 4 months ago (2017-08-21 11:09:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_api_framework on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/builds/10519)
3 years, 4 months ago (2017-08-21 11:17:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2990253002/1
3 years, 4 months ago (2017-08-21 13:25:34 UTC) #15
commit-bot: I haz the power
3 years, 4 months ago (2017-08-21 14:12:14 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b0215daeb5ad6b686abb300fd...

Powered by Google App Engine
This is Rietveld 408576698