Input signal creation for non-existing input signal files

TestDataGenerators attempts to create missing input signal files.
If the input file name matches the "<name>-<params>.wav" pattern and <name> is a valid signal creator name, then <params> is parsed and used to create a new signal which is written in place of the missing file.

This CL only adds a pure tone creator. For instance, 'pure_tone-440_1000.wav' creates a pure tone at 440 Hz, 1000 ms long, mono, sampled at 48kHz.

This feature can be used to simplify the creation of common probe signals - no need to add external .wav files. Also, it will be exploited by a coming CL that adds a new evaluation score requiring the input signal to be a pure tone.

Additional minor fixes:
- apm_quality_assessment_unittest.py: command line arguments replaced to avoid that those for the unit test framework are passed
- simulation_unittest.py: invalid evaluation score name replaced

BUG=webrtc:7218
Review-Url: https://codereview.webrtc.org/2989823002
Cr-Commit-Position: refs/heads/master@{#19200}
Committed: https://chromium.googlesource.com/external/webrtc/+/ddfa252b50953e2a0e3b35af21739e70e4345208

[AleBzk, 2017-07-27 14:54:48]

Description was changed from

==========
TestDataGenerator._CreateInputSignal() as class method


InputSignalCreator with class methods only


input signal creation for non-existing input signal files

BUG=
==========

to

==========
TestTestDataGenerators attempts to create missing input signal files.
If the input file name matches the "<name>-<params>.wav" pattern and <name> is a
valid signal creator name, then <params> is parsed and used to create a new
signal which is written in place of the missing file.

This CL only adds a pure tone creator. For instance, 'pure_tone-440_1000.wav'
creates a pure tone at 440 Hz, 1000 ms long, mono, sampled at 48kHz.

This feature can be used to simplify the creation of common probe signals - no
need to add external .wav files. Also, it will be exploited by a coming CL that
adds a new evaluation score requiring the input signal to be a pure tone.

BUG=webrtc:7218
==========

[AleBzk, 2017-07-27 14:54:48]

alessiob@webrtc.org changed reviewers:
+ aleloi@webrtc.org

[AleBzk, 2017-07-27 14:57:17]

Description was changed from

==========
TestTestDataGenerators attempts to create missing input signal files.
If the input file name matches the "<name>-<params>.wav" pattern and <name> is a
valid signal creator name, then <params> is parsed and used to create a new
signal which is written in place of the missing file.

This CL only adds a pure tone creator. For instance, 'pure_tone-440_1000.wav'
creates a pure tone at 440 Hz, 1000 ms long, mono, sampled at 48kHz.

This feature can be used to simplify the creation of common probe signals - no
need to add external .wav files. Also, it will be exploited by a coming CL that
adds a new evaluation score requiring the input signal to be a pure tone.

BUG=webrtc:7218
==========

to

==========
TestTestDataGenerators attempts to create missing input signal files.
If the input file name matches the "<name>-<params>.wav" pattern and <name> is a
valid signal creator name, then <params> is parsed and used to create a new
signal which is written in place of the missing file.

This CL only adds a pure tone creator. For instance, 'pure_tone-440_1000.wav'
creates a pure tone at 440 Hz, 1000 ms long, mono, sampled at 48kHz.

This feature can be used to simplify the creation of common probe signals - no
need to add external .wav files. Also, it will be exploited by a coming CL that
adds a new evaluation score requiring the input signal to be a pure tone.

Additional minor changes:
- apm_quality_assessment_unittest.py: command line arguments replaced to avoid
that those for the unit test framework are passed.

BUG=webrtc:7218
==========

[AleBzk, 2017-07-27 14:59:13]

Description was changed from

==========
TestTestDataGenerators attempts to create missing input signal files.
If the input file name matches the "<name>-<params>.wav" pattern and <name> is a
valid signal creator name, then <params> is parsed and used to create a new
signal which is written in place of the missing file.

This CL only adds a pure tone creator. For instance, 'pure_tone-440_1000.wav'
creates a pure tone at 440 Hz, 1000 ms long, mono, sampled at 48kHz.

This feature can be used to simplify the creation of common probe signals - no
need to add external .wav files. Also, it will be exploited by a coming CL that
adds a new evaluation score requiring the input signal to be a pure tone.

Additional minor changes:
- apm_quality_assessment_unittest.py: command line arguments replaced to avoid
that those for the unit test framework are passed.

BUG=webrtc:7218
==========

to

==========
TestTestDataGenerators attempts to create missing input signal files.
If the input file name matches the "<name>-<params>.wav" pattern and <name> is a
valid signal creator name, then <params> is parsed and used to create a new
signal which is written in place of the missing file.

This CL only adds a pure tone creator. For instance, 'pure_tone-440_1000.wav'
creates a pure tone at 440 Hz, 1000 ms long, mono, sampled at 48kHz.

This feature can be used to simplify the creation of common probe signals - no
need to add external .wav files. Also, it will be exploited by a coming CL that
adds a new evaluation score requiring the input signal to be a pure tone.

Additional minor fixes:
- apm_quality_assessment_unittest.py: command line arguments replaced to avoid
that those for the unit test framework are passed
- simulation_unittest.py: invalid evaluation score name replaced

BUG=webrtc:7218
==========

[AleBzk, 2017-07-27 14:59:54]

Hi Alex, PTAL!

Alessio

[aleloi, 2017-07-28 09:01:29]

LGTM + one comment.

TestTestDataGenerators in the description should be TestDataGenerators, right?

https://codereview.webrtc.org/2989823002/diff/1/webrtc/modules/audio_processi...
File
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/test_data_generation.py
(right):

https://codereview.webrtc.org/2989823002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/test_data_generation.py:147:
print(input_signal_filepath, filename, filename_parts)
Should probably be removed now?

[AleBzk, 2017-07-28 12:17:41]

Description was changed from

==========
TestTestDataGenerators attempts to create missing input signal files.
If the input file name matches the "<name>-<params>.wav" pattern and <name> is a
valid signal creator name, then <params> is parsed and used to create a new
signal which is written in place of the missing file.

This CL only adds a pure tone creator. For instance, 'pure_tone-440_1000.wav'
creates a pure tone at 440 Hz, 1000 ms long, mono, sampled at 48kHz.

This feature can be used to simplify the creation of common probe signals - no
need to add external .wav files. Also, it will be exploited by a coming CL that
adds a new evaluation score requiring the input signal to be a pure tone.

Additional minor fixes:
- apm_quality_assessment_unittest.py: command line arguments replaced to avoid
that those for the unit test framework are passed
- simulation_unittest.py: invalid evaluation score name replaced

BUG=webrtc:7218
==========

to

==========
TestDataGenerators attempts to create missing input signal files.
If the input file name matches the "<name>-<params>.wav" pattern and <name> is a
valid signal creator name, then <params> is parsed and used to create a new
signal which is written in place of the missing file.

This CL only adds a pure tone creator. For instance, 'pure_tone-440_1000.wav'
creates a pure tone at 440 Hz, 1000 ms long, mono, sampled at 48kHz.

This feature can be used to simplify the creation of common probe signals - no
need to add external .wav files. Also, it will be exploited by a coming CL that
adds a new evaluation score requiring the input signal to be a pure tone.

Additional minor fixes:
- apm_quality_assessment_unittest.py: command line arguments replaced to avoid
that those for the unit test framework are passed
- simulation_unittest.py: invalid evaluation score name replaced

BUG=webrtc:7218
==========

[AleBzk, 2017-07-28 14:26:11]

https://codereview.webrtc.org/2989823002/diff/1/webrtc/modules/audio_processi...
File
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/test_data_generation.py
(right):

https://codereview.webrtc.org/2989823002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/test_data_generation.py:147:
print(input_signal_filepath, filename, filename_parts)
On 2017/07/28 09:01:29, aleloi wrote:
> Should probably be removed now?

Done.

[AleBzk, 2017-08-01 11:57:14]

The CQ bit was checked by alessiob@webrtc.org

[AleBzk, 2017-08-01 11:57:15]

The patchset sent to the CQ was uploaded after l-g-t-m from aleloi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2989823002/#ps40001 (title:
"merge")

[commit-bot: I haz the power, 2017-08-01 11:57:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-01 12:04:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-01 12:04:56]

Try jobs failed on following builders:
  linux_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm64_dbg/builds/...)

[AleBzk, 2017-08-01 12:33:16]

The CQ bit was checked by alessiob@webrtc.org

[commit-bot: I haz the power, 2017-08-01 12:33:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-01 12:44:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1501590796474020,
"parent_rev": "a25a69582edf086934b1d8576b6410815f67add7", "commit_rev":
"ddfa252b50953e2a0e3b35af21739e70e4345208"}

[commit-bot: I haz the power, 2017-08-01 12:44:24]

Description was changed from

==========
TestDataGenerators attempts to create missing input signal files.
If the input file name matches the "<name>-<params>.wav" pattern and <name> is a
valid signal creator name, then <params> is parsed and used to create a new
signal which is written in place of the missing file.

This CL only adds a pure tone creator. For instance, 'pure_tone-440_1000.wav'
creates a pure tone at 440 Hz, 1000 ms long, mono, sampled at 48kHz.

This feature can be used to simplify the creation of common probe signals - no
need to add external .wav files. Also, it will be exploited by a coming CL that
adds a new evaluation score requiring the input signal to be a pure tone.

Additional minor fixes:
- apm_quality_assessment_unittest.py: command line arguments replaced to avoid
that those for the unit test framework are passed
- simulation_unittest.py: invalid evaluation score name replaced

BUG=webrtc:7218
==========

to

==========
TestDataGenerators attempts to create missing input signal files.
If the input file name matches the "<name>-<params>.wav" pattern and <name> is a
valid signal creator name, then <params> is parsed and used to create a new
signal which is written in place of the missing file.

This CL only adds a pure tone creator. For instance, 'pure_tone-440_1000.wav'
creates a pure tone at 440 Hz, 1000 ms long, mono, sampled at 48kHz.

This feature can be used to simplify the creation of common probe signals - no
need to add external .wav files. Also, it will be exploited by a coming CL that
adds a new evaluation score requiring the input signal to be a pure tone.

Additional minor fixes:
- apm_quality_assessment_unittest.py: command line arguments replaced to avoid
that those for the unit test framework are passed
- simulation_unittest.py: invalid evaluation score name replaced

BUG=webrtc:7218

Review-Url: https://codereview.webrtc.org/2989823002
Cr-Commit-Position: refs/heads/master@{#19200}
Committed:
https://chromium.googlesource.com/external/webrtc/+/ddfa252b50953e2a0e3b35af2...
==========

[commit-bot: I haz the power, 2017-08-01 12:44:26]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/ddfa252b50953e2a0e3b35af2...