Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2989703002: buildbucket: use acl sets (Closed)

Created:
3 years, 4 months ago by nodir1
Modified:
3 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/infra/config
Project:
webrtc
Visibility:
Public.

Description

buildbucket: use acl sets There is a lot of repetition in ACLs of buildbucket buckets. Use acl_sets feature to reduce repetition R=kjellander@webrtc.org BUG= NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.webrtc.org/2989703002 Committed: https://chromium.googlesource.com/external/webrtc/+/e5aa02d40c727f70c8bbc0c29d32d9825661cbc4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -34 lines) Patch
M cr-buildbucket.cfg View 2 chunks +13 lines, -34 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
nodir1
PTAL
3 years, 4 months ago (2017-07-26 09:04:55 UTC) #1
kjellander_webrtc
lgtm
3 years, 4 months ago (2017-07-26 09:21:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2989703002/1
3 years, 4 months ago (2017-07-27 10:22:16 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-07-27 10:22:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/e5aa02d40c727f70c8bbc0c29...

Powered by Google App Engine
This is Rietveld 408576698