Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: webrtc/test/testsupport/test_output.h

Issue 2989613002: Rename isolated_output to test_output and add a method to get the test_output directory. (Closed)
Patch Set: Fix CE Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/test/testsupport/isolated_output_unittest.cc ('k') | webrtc/test/testsupport/test_output.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/test/testsupport/test_output.h
diff --git a/webrtc/test/testsupport/isolated_output.h b/webrtc/test/testsupport/test_output.h
similarity index 63%
rename from webrtc/test/testsupport/isolated_output.h
rename to webrtc/test/testsupport/test_output.h
index f4e9695157101ae940d41387b9ee137028996675..c502ea38d97765b64a2ea3d86d23d164c5465c08 100644
--- a/webrtc/test/testsupport/isolated_output.h
+++ b/webrtc/test/testsupport/test_output.h
@@ -8,8 +8,8 @@
* be found in the AUTHORS file in the root of the source tree.
*/
-#ifndef WEBRTC_TEST_TESTSUPPORT_ISOLATED_OUTPUT_H_
-#define WEBRTC_TEST_TESTSUPPORT_ISOLATED_OUTPUT_H_
+#ifndef WEBRTC_TEST_TESTSUPPORT_TEST_OUTPUT_H_
+#define WEBRTC_TEST_TESTSUPPORT_TEST_OUTPUT_H_
#include <stdlib.h>
@@ -18,18 +18,22 @@
namespace webrtc {
namespace test {
+// If the test_output_dir flag is set, returns true and copies the location of
+// the dir to |out_dir|. Otherwise, return false.
+bool GetTestOutputDir(std::string* out_dir);
+
// Writes a |length| bytes array |buffer| to |filename| in isolated output
// directory defined by swarming. If the file is existing, content will be
// appended. Otherwise a new file will be created. This function returns false
// if isolated output directory has not been defined, or |filename| indicates an
// invalid or non-writable file, or underlying file system errors.
-bool WriteIsolatedOutput(const char* filename,
- const uint8_t* buffer,
- size_t length);
+bool WriteToTestOutput(const char* filename,
+ const uint8_t* buffer,
+ size_t length);
-bool WriteIsolatedOutput(const char* filename, const std::string& content);
+bool WriteToTestOutput(const char* filename, const std::string& content);
} // namespace test
} // namespace webrtc
-#endif // WEBRTC_TEST_TESTSUPPORT_ISOLATED_OUTPUT_H_
+#endif // WEBRTC_TEST_TESTSUPPORT_TEST_OUTPUT_H_
« no previous file with comments | « webrtc/test/testsupport/isolated_output_unittest.cc ('k') | webrtc/test/testsupport/test_output.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698