Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2989603002: Fix autoroller in accordance to upstream change (Closed)

Created:
3 years, 5 months ago by oprypin_webrtc
Modified:
3 years, 5 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix autoroller in accordance to upstream change This broke WebRTC's presubmit https://chromium.googlesource.com/chromium/tools/depot_tools/+/e79ddeaabf246769937282f952897bcec3e9de05%5E%21/ GClientKeywords has been removed and replaced with a more direct substitution. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2989603002 Cr-Commit-Position: refs/heads/master@{#19126} Committed: https://chromium.googlesource.com/external/webrtc/+/1e64cfae533d0c83c7878401f7213ba4b847940d

Patch Set 1 : Fix autoroller in accordance to upstream change #

Patch Set 2 : Add unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M tools_webrtc/autoroller/roll_deps.py View 1 2 chunks +5 lines, -3 lines 0 comments Download
M tools_webrtc/autoroller/unittests/roll_deps_test.py View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
oprypin_webrtc
3 years, 5 months ago (2017-07-25 08:44:38 UTC) #4
kjellander_webrtc
lgtm
3 years, 5 months ago (2017-07-25 08:49:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2989603002/40001
3 years, 5 months ago (2017-07-25 08:53:26 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-25 08:57:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/1e64cfae533d0c83c7878401f...

Powered by Google App Engine
This is Rietveld 408576698