Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2989513002: [VM generic functions] Disallow generic function types as type arguments or bounds. (Closed)

Created:
3 years, 5 months ago by regis
Modified:
3 years, 5 months ago
Reviewers:
Leaf, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[VM generic functions] Disallow generic function types as type arguments or bounds. Adjust existing test and status file. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/cc81f38519b530f8dba6e46d82bc3c9554f5ce3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -8 lines) Patch
M runtime/vm/class_finalizer.cc View 3 chunks +37 lines, -0 lines 0 comments Download
M tests/language_2/generic_methods_generic_function_result_test.dart View 1 chunk +12 lines, -6 lines 0 comments Download
M tests/language_2/language_2.status View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
regis
3 years, 5 months ago (2017-07-21 21:18:52 UTC) #2
siva
lgtm
3 years, 5 months ago (2017-07-21 21:59:50 UTC) #3
regis
Committed patchset #1 (id:1) manually as cc81f38519b530f8dba6e46d82bc3c9554f5ce3d.
3 years, 5 months ago (2017-07-21 22:08:06 UTC) #5
Leaf
3 years, 5 months ago (2017-07-21 22:13:32 UTC) #6
Message was sent while issue was closed.
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698