runtime/vm/source_report.cc - Issue 2989493002: Simplify and fix implicit closure check, speed up Closure_equals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/source_report.cc

Issue 2989493002: Simplify and fix implicit closure check, speed up Closure_equals (Closed)

Patch Set: Avoid overloaded NewClosureFunction Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/source_report.cc

diff --git a/runtime/vm/source_report.cc b/runtime/vm/source_report.cc

index e703cfab97e3301af991380b529f8b0246545046..6baf9ce085848910e52d9e26872f41f4cf894dc8 100644

--- a/runtime/vm/source_report.cc

+++ b/runtime/vm/source_report.cc

@@ -82,6 +82,7 @@ bool SourceReport::ShouldSkipFunction(const Function& func) {

switch (func.kind()) {

case RawFunction::kRegularFunction:

case RawFunction::kClosureFunction:

+ case RawFunction::kImplicitClosureFunction:

case RawFunction::kGetterFunction:

case RawFunction::kSetterFunction:

case RawFunction::kConstructor: