Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: runtime/vm/parser.cc

Issue 2989493002: Simplify and fix implicit closure check, speed up Closure_equals (Closed)
Patch Set: Avoid overloaded NewClosureFunction Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index b12463c9fa408f2b1408e50944f93bdd1f68cf81..f555b6d62fb2da5536b4ba7e7cde3f1842b389e1 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -1089,11 +1089,10 @@ void Parser::ParseFunction(ParsedFunction* parsed_function) {
#endif // !PRODUCT
SequenceNode* node_sequence = NULL;
switch (func.kind()) {
+ case RawFunction::kImplicitClosureFunction:
+ node_sequence = parser.ParseImplicitClosure(func);
+ break;
case RawFunction::kClosureFunction:
- if (func.IsImplicitClosureFunction()) {
- node_sequence = parser.ParseImplicitClosure(func);
- break;
- }
if (func.IsConstructorClosureFunction()) {
node_sequence = parser.ParseConstructorClosure(func);
break;
« runtime/lib/function.cc ('K') | « runtime/vm/object.cc ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698