Add support for compiling Dart via the FE in dart2js.

Add support for compiling Dart via the FE in dart2js.

This also:
 - replaces --use-kernel with --use-kernel-in-ssa
 - replaces --load-dill with --use-kernel
 - makes --use-kernel support both: compiling from .dill or from .dart
 - change the default of other options that are currently disabled when --use-kernel is on.
 - adds .status lines for all tests in language/corelib/dart2js_extra/dart2js_native

R=efortuna@google.com

 Note: this CL is built on top of another change
 (https://codereview.chromium.org/2981403002/) that adds preview_dart_2 to
 test.dart
Committed: https://github.com/dart-lang/sdk/commit/09ff1b56f79ba855a5ef7149be2f7bc6536154ec

[Siggi Cherem (dart-lang), 2017-07-21 18:50:24]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2017-07-21 18:50:29]

Patchset #1 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2017-07-21 19:17:35]

Patchset #1 (id:40001) has been deleted

[Siggi Cherem (dart-lang), 2017-07-21 19:18:21]

Description was changed from

==========
Add support for compiling Dart via the FE in dart2js.

This also:
 - replaces --load-dill with --preview-dart-2 (unifying on the flag with other
   tools)
 - makes --preview-dart-2 support both: compiling from .dill or from .dart
 - change the default of other options that are currently disabled when
   --preview-dart-2 is on.
 - adds .status lines for all tests in
language/corelib/dart2js_extra/dart2js_native

 Note: this CL is built on top of another change
 (https://codereview.chromium.org/2981403002/) that adds preview_dart_2 to
 test.dart
==========

to

==========
Add support for compiling Dart via the FE in dart2js.

This also:
 - replaces --load-dill with --preview-dart-2 (unifying on the flag with other
   tools)
 - makes --preview-dart-2 support both: compiling from .dill or from .dart
 - change the default of other options that are currently disabled when
   --preview-dart-2 is on.
 - adds .status lines for all tests in
language/corelib/dart2js_extra/dart2js_native

 Note: this CL is built on top of another change
 (https://codereview.chromium.org/2981403002/) that adds preview_dart_2 to
 test.dart
==========

[Siggi Cherem (dart-lang), 2017-07-21 19:21:30]

sigmund@google.com changed reviewers:
+ efortuna@google.com, johnniwinther@google.com, sra@google.com

[Siggi Cherem (dart-lang), 2017-07-21 19:21:32]

FYI - no need for all 3 of you to review, just whoever gets to it first is good.

Together with the other CL, we'll be able to do:

test.py -c dart2js -r d8 --preview-dart-2 language

Running all tests (but without host_checked) yields about 55% tests are already
passing!

https://codereview.chromium.org/2989453002/diff/60001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/dart2js_target.dart (right):

https://codereview.chromium.org/2989453002/diff/60001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/dart2js_target.dart:12: import
'../native/native.dart' show maybeEnableNative;
this caused problems because sdk/bin/dart2js is importing dart2js.dart in the
lib folder directly without using a package:* URI. I think we should fix that

https://codereview.chromium.org/2989453002/diff/60001/tests/compiler/dart2js_...
File tests/compiler/dart2js_extra/dart2js_extra.status (right):

https://codereview.chromium.org/2989453002/diff/60001/tests/compiler/dart2js_...
tests/compiler/dart2js_extra/dart2js_extra.status:169: [ $compiler == dart2js &&
$preview_dart_2 ]
so far I added these without --host-checked, I'll add the rest before landing
this CL.

[Emily Fortuna, 2017-07-21 21:50:51]

lgtm

https://codereview.chromium.org/2989453002/diff/60001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/dart2js_target.dart (right):

https://codereview.chromium.org/2989453002/diff/60001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/dart2js_target.dart:12: import
'../native/native.dart' show maybeEnableNative;
On 2017/07/21 19:21:31, Siggi Cherem (dart-lang) wrote:
> this caused problems because sdk/bin/dart2js is importing dart2js.dart in the
> lib folder directly without using a package:* URI. I think we should fix that

add a TODO about it?

https://codereview.chromium.org/2989453002/diff/60001/pkg/compiler/lib/src/op...
File pkg/compiler/lib/src/options.dart (right):

https://codereview.chromium.org/2989453002/diff/60001/pkg/compiler/lib/src/op...
pkg/compiler/lib/src/options.dart:475: useKernel: useKernel || previewDart2,
can we delete this option, too?

https://codereview.chromium.org/2989453002/diff/60001/tests/compiler/dart2js/...
File tests/compiler/dart2js/analyze_unused_dart2js_test.dart (right):

https://codereview.chromium.org/2989453002/diff/60001/tests/compiler/dart2js/...
tests/compiler/dart2js/analyze_unused_dart2js_test.dart:19: //
TODO(johnniwinther): uncomment when [Compiler.reportUnusedCode] is reenabled.
should we file a bug so Johnni is aware of this?

[Siggi Cherem (dart-lang), 2017-07-22 00:00:58]

Description was changed from

==========
Add support for compiling Dart via the FE in dart2js.

This also:
 - replaces --load-dill with --preview-dart-2 (unifying on the flag with other
   tools)
 - makes --preview-dart-2 support both: compiling from .dill or from .dart
 - change the default of other options that are currently disabled when
   --preview-dart-2 is on.
 - adds .status lines for all tests in
language/corelib/dart2js_extra/dart2js_native

 Note: this CL is built on top of another change
 (https://codereview.chromium.org/2981403002/) that adds preview_dart_2 to
 test.dart
==========

to

==========
Add support for compiling Dart via the FE in dart2js.

This also:
 - replaces --use-kernel with --use-kernel-in-ssa
 - replaces --load-dill with --use-kernel
 - makes --use-kernel support both: compiling from .dill or from .dart
 - change the default of other options that are currently disabled when
--use-kernel is on.
 - adds .status lines for all tests in
language/corelib/dart2js_extra/dart2js_native

 Note: this CL is built on top of another change
 (https://codereview.chromium.org/2981403002/) that adds preview_dart_2 to
 test.dart
==========

[Siggi Cherem (dart-lang), 2017-07-22 00:04:04]

Thanks Emily!

After talking with Bob, we decided to not use '--preview-dart-2', but a
dart2js-specific flag. 

I decided to shuffle our flags a bit:
  * I renamed '--use-kernel' to '--use-kernel-in-ssa' to reflect what it
actually does
  * I now use '--use-kernel' to mean use the kernel_strategy everywhere (this
includes using the new FE)

In the future, once strong-mode is operational in the FE, we could use
'--strong' instead of `--use-kernel`

https://codereview.chromium.org/2989453002/diff/60001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/dart2js_target.dart (right):

https://codereview.chromium.org/2989453002/diff/60001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/dart2js_target.dart:12: import
'../native/native.dart' show maybeEnableNative;
On 2017/07/21 21:50:51, Emily Fortuna wrote:
> On 2017/07/21 19:21:31, Siggi Cherem (dart-lang) wrote:
> > this caused problems because sdk/bin/dart2js is importing dart2js.dart in
the
> > lib folder directly without using a package:* URI. I think we should fix
that
> 
> add a TODO about it?

I wanted too, but I wasn't sure where :) - we use relative imports everywhere
because of this.

I filed a bug: https://github.com/dart-lang/sdk/issues/30233

https://codereview.chromium.org/2989453002/diff/60001/pkg/compiler/lib/src/op...
File pkg/compiler/lib/src/options.dart (right):

https://codereview.chromium.org/2989453002/diff/60001/pkg/compiler/lib/src/op...
pkg/compiler/lib/src/options.dart:475: useKernel: useKernel || previewDart2,
On 2017/07/21 21:50:51, Emily Fortuna wrote:
> can we delete this option, too?

Great question - we chatted a bit about this offline and I was quite ambivalent
at first. I lean towards keeping the two flags for a little longer because we
are not getting much coverage from the ssa builder otherwise (in particular, we
need to fix an issue with the `FE` not allowing dart:_internal imports in tests
(all dart2js_native tests fail for this reason), and land a few other changes in
the pipeline). Let's chat more about this when we are all together next week
though.

https://codereview.chromium.org/2989453002/diff/60001/tests/compiler/dart2js/...
File tests/compiler/dart2js/analyze_unused_dart2js_test.dart (right):

https://codereview.chromium.org/2989453002/diff/60001/tests/compiler/dart2js/...
tests/compiler/dart2js/analyze_unused_dart2js_test.dart:19: //
TODO(johnniwinther): uncomment when [Compiler.reportUnusedCode] is reenabled.
On 2017/07/21 21:50:51, Emily Fortuna wrote:
> should we file a bug so Johnni is aware of this?

Oh, I just moved the TODO from down below :)

[Siggi Cherem (dart-lang), 2017-07-22 00:06:46]

Patchset #2 (id:80001) has been deleted

[Siggi Cherem (dart-lang), 2017-07-25 00:08:10]

Patchset #3 (id:120001) has been deleted

[Siggi Cherem (dart-lang), 2017-07-25 00:10:16]

Description was changed from

==========
Add support for compiling Dart via the FE in dart2js.

This also:
 - replaces --use-kernel with --use-kernel-in-ssa
 - replaces --load-dill with --use-kernel
 - makes --use-kernel support both: compiling from .dill or from .dart
 - change the default of other options that are currently disabled when
--use-kernel is on.
 - adds .status lines for all tests in
language/corelib/dart2js_extra/dart2js_native

 Note: this CL is built on top of another change
 (https://codereview.chromium.org/2981403002/) that adds preview_dart_2 to
 test.dart
==========

to

==========
Add support for compiling Dart via the FE in dart2js.

This also:
 - replaces --use-kernel with --use-kernel-in-ssa
 - replaces --load-dill with --use-kernel
 - makes --use-kernel support both: compiling from .dill or from .dart
 - change the default of other options that are currently disabled when
--use-kernel is on.
 - adds .status lines for all tests in
language/corelib/dart2js_extra/dart2js_native

R=efortuna@google.com

 Note: this CL is built on top of another change
 (https://codereview.chromium.org/2981403002/) that adds preview_dart_2 to
 test.dart
Committed:
https://github.com/dart-lang/sdk/commit/09ff1b56f79ba855a5ef7149be2f7bc6536154ec
==========

[Siggi Cherem (dart-lang), 2017-07-25 00:10:21]

Committed patchset #3 (id:140001) manually as
09ff1b56f79ba855a5ef7149be2f7bc6536154ec (presubmit successful).

[Johnni Winther, 2017-07-28 12:26:42]

https://codereview.chromium.org/2989453002/diff/140001/pkg/compiler/lib/src/k...
File pkg/compiler/lib/src/kernel/front_end_adapter.dart (right):

https://codereview.chromium.org/2989453002/diff/140001/pkg/compiler/lib/src/k...
pkg/compiler/lib/src/kernel/front_end_adapter.dart:85: case
fe.Severity.internalProblem:
I think `internalProblem` should map to a crash (which doesn't have a
corresponding report method on [DiagnosticReporter].

[Siggi Cherem (dart-lang), 2017-07-28 19:15:51]

https://codereview.chromium.org/2989453002/diff/140001/pkg/compiler/lib/src/k...
File pkg/compiler/lib/src/kernel/front_end_adapter.dart (right):

https://codereview.chromium.org/2989453002/diff/140001/pkg/compiler/lib/src/k...
pkg/compiler/lib/src/kernel/front_end_adapter.dart:85: case
fe.Severity.internalProblem:
On 2017/07/28 12:26:42, Johnni Winther wrote:
> I think `internalProblem` should map to a crash (which doesn't have a
> corresponding report method on [DiagnosticReporter].

good point, I guess I can make it throw here, I'll send you a fix shortly.