Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2989323002: Revert of Break peerconnection_jni.cc into multiple files, in "pc" directory. (Closed)

Created:
3 years, 4 months ago by Zhi Huang
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Break peerconnection_jni.cc into multiple files, in "pc" directory. (patchset #6 id:100001 of https://codereview.webrtc.org/2992103002/ ) Reason for revert: Borken in the internal projects. Original issue's description: > Break peerconnection_jni.cc into multiple files, in "pc" directory. > > This CL breaks peerconnection_jni.cc apart, into one file for each > class. It also moves the methods for converting between C++/Java > structs into "java_native_conversion.cc", and uses a consistent naming > scheme ("JavaToNativeX, NativeToJavaX"). These files go into a new > "pc" directory, of which deadbeef@ is added as an owner. > > It also moves some relevant files to the "pc" directory that belong > there: ownedfactoryandthreads, androidnetworkmonitor_jni, and > rtcstatscollectorcallbackwrapper. This directory is intended to hold > all the files that deal with the PeerConnection API specifically, or > related classes (like DataChannel, RtpSender, MediaStreamTrack) that > are tied to it closely. > > deadbeef@webrtc.org is added as an owner of the new "pc" subdirectory. > > BUG=webrtc:8055 > > Review-Url: https://codereview.webrtc.org/2992103002 > Cr-Commit-Position: refs/heads/master@{#19223} > Committed: https://chromium.googlesource.com/external/webrtc/+/dd7d8f1b609d51bcf39e9585871967a694a856bb TBR=magjed@webrtc.org,sakal@webrtc.org,deadbeef@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:8055 Review-Url: https://codereview.webrtc.org/2989323002 Cr-Commit-Position: refs/heads/master@{#19226} Committed: https://chromium.googlesource.com/external/webrtc/+/1b1daec01379165910e3c253fc42ddf08d130874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3796 lines, -4406 lines) Patch
M webrtc/sdk/android/BUILD.gn View 9 chunks +16 lines, -41 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidmediacodeccommon.h View 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc View 1 chunk +0 lines, -1 line 0 comments Download
A webrtc/sdk/android/src/jni/androidnetworkmonitor_jni.h View 1 chunk +97 lines, -0 lines 0 comments Download
A webrtc/sdk/android/src/jni/androidnetworkmonitor_jni.cc View 1 chunk +433 lines, -0 lines 0 comments Download
A webrtc/sdk/android/src/jni/audio_jni.h View 1 chunk +28 lines, -0 lines 0 comments Download
A webrtc/sdk/android/src/jni/audio_jni.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/classreferenceholder.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/jni_helpers.h View 2 chunks +0 lines, -23 lines 0 comments Download
M webrtc/sdk/android/src/jni/jni_helpers.cc View 1 chunk +0 lines, -8 lines 0 comments Download
A webrtc/sdk/android/src/jni/media_jni.h View 1 chunk +48 lines, -0 lines 0 comments Download
A webrtc/sdk/android/src/jni/media_jni.cc View 1 chunk +41 lines, -0 lines 0 comments Download
A webrtc/sdk/android/src/jni/null_audio_jni.cc View 1 chunk +22 lines, -0 lines 0 comments Download
A webrtc/sdk/android/src/jni/null_media_jni.cc View 1 chunk +35 lines, -0 lines 0 comments Download
A webrtc/sdk/android/src/jni/null_video_jni.cc View 1 chunk +32 lines, -0 lines 0 comments Download
A webrtc/sdk/android/src/jni/ownedfactoryandthreads.h View 1 chunk +80 lines, -0 lines 0 comments Download
A webrtc/sdk/android/src/jni/ownedfactoryandthreads.cc View 1 chunk +64 lines, -0 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/sdk/android/src/jni/pc/androidnetworkmonitor_jni.h View 1 chunk +0 lines, -97 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/androidnetworkmonitor_jni.cc View 1 chunk +0 lines, -436 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/audio_jni.h View 1 chunk +0 lines, -28 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/audio_jni.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/audiotrack_jni.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/callsessionfilerotatinglogsink_jni.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/datachannel_jni.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/datachannelobserver_jni.h View 1 chunk +0 lines, -42 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/datachannelobserver_jni.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/dtmfsender_jni.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/java_native_conversion.h View 1 chunk +0 lines, -112 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/java_native_conversion.cc View 1 chunk +0 lines, -700 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/logging_jni.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/media_jni.h View 1 chunk +0 lines, -48 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/media_jni.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/mediaconstraints_jni.h View 1 chunk +0 lines, -43 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/mediaconstraints_jni.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/mediasource_jni.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/mediastream_jni.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/mediastreamtrack_jni.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/null_audio_jni.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/null_media_jni.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/null_video_jni.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/ownedfactoryandthreads.h View 1 chunk +0 lines, -80 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/ownedfactoryandthreads.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/peerconnection_jni.cc View 1 chunk +0 lines, -325 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/peerconnectionfactory_jni.cc View 1 chunk +0 lines, -322 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/peerconnectionobserver_jni.h View 1 chunk +0 lines, -100 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/peerconnectionobserver_jni.cc View 1 chunk +0 lines, -307 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/rtcstatscollectorcallbackwrapper.h View 1 chunk +0 lines, -65 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/rtcstatscollectorcallbackwrapper.cc View 1 chunk +0 lines, -267 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/rtpreceiver_jni.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/rtpreceiverobserver_jni.h View 1 chunk +0 lines, -37 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/rtpreceiverobserver_jni.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/rtpsender_jni.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/sdpobserver_jni.h View 1 chunk +0 lines, -108 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/statsobserver_jni.h View 1 chunk +0 lines, -43 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/statsobserver_jni.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/video_jni.h View 1 chunk +0 lines, -40 lines 0 comments Download
D webrtc/sdk/android/src/jni/pc/video_jni.cc View 1 chunk +0 lines, -121 lines 0 comments Download
A webrtc/sdk/android/src/jni/peerconnection_jni.cc View 1 chunk +2367 lines, -0 lines 0 comments Download
A webrtc/sdk/android/src/jni/rtcstatscollectorcallbackwrapper.h View 1 chunk +65 lines, -0 lines 0 comments Download
A webrtc/sdk/android/src/jni/rtcstatscollectorcallbackwrapper.cc View 1 chunk +267 lines, -0 lines 0 comments Download
A webrtc/sdk/android/src/jni/video_jni.h View 1 chunk +40 lines, -0 lines 0 comments Download
A webrtc/sdk/android/src/jni/video_jni.cc View 1 chunk +121 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Zhi Huang
Created Revert of Break peerconnection_jni.cc into multiple files, in "pc" directory.
3 years, 4 months ago (2017-08-03 01:00:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2989323002/1
3 years, 4 months ago (2017-08-03 01:00:46 UTC) #3
commit-bot: I haz the power
3 years, 4 months ago (2017-08-03 01:01:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/1b1daec01379165910e3c253f...

Powered by Google App Engine
This is Rietveld 408576698