Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2989313003: Reland of Fix off-by-one bugs in PacketBuffer when the buffer is filled with a single frame. (Closed)

Created:
3 years, 4 months ago by philipel
Modified:
3 years, 4 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Fix off-by-one bugs in video_coding::PacketBuffer when the buffer is filled with a single frame. (patchset #1 id:1 of https://codereview.chromium.org/2990183002/ ) Reason for revert: Revert to create fix CL. Original issue's description: > Revert of Fix off-by-one bugs in video_coding::PacketBuffer when the buffer is filled with a single frame. (patchset #5 id:80001 of https://codereview.chromium.org/2993513002/ ) > > Reason for revert: > Break performance bots. > > Original issue's description: > > Fix off-by-one bugs in video_coding::PacketBuffer when the buffer is filled with a single frame. > > > > BUG=webrtc:8028 > > > > Review-Url: https://codereview.webrtc.org/2993513002 > > Cr-Commit-Position: refs/heads/master@{#19209} > > Committed: https://chromium.googlesource.com/external/webrtc/+/ee13e8919c20de5860a510e91fac71fd5a7e9b8d > > TBR=stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:8028 > > Review-Url: https://codereview.webrtc.org/2990183002 > Cr-Commit-Position: refs/heads/master@{#19211} > Committed: https://chromium.googlesource.com/external/webrtc/+/c18f1d7c9432a2bf7d112820eb2b1dd2dbe2ba4b TBR=stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:8028 TBR=stefan@webrtc.org Review-Url: https://codereview.webrtc.org/2989313003 Cr-Commit-Position: refs/heads/master@{#19249} Committed: https://chromium.googlesource.com/external/webrtc/+/227f8b9be8866990a4ef341000a66b1c1d3d4e75

Patch Set 1 #

Patch Set 2 : facepalm #

Patch Set 3 : Unittest #

Patch Set 4 : Memcpy fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -10 lines) Patch
M webrtc/modules/video_coding/frame_object.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/frame_object.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/packet_buffer.cc View 1 3 chunks +20 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/video_packet_buffer_unittest.cc View 1 2 3 3 chunks +86 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
philipel
Created Reland of Fix off-by-one bugs in video_coding::PacketBuffer when the buffer is filled with a ...
3 years, 4 months ago (2017-08-03 08:52:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2989313003/140001
3 years, 4 months ago (2017-08-04 09:37:19 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_memcheck on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/10184)
3 years, 4 months ago (2017-08-04 10:16:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2989313003/160001
3 years, 4 months ago (2017-08-04 13:02:21 UTC) #8
commit-bot: I haz the power
3 years, 4 months ago (2017-08-04 13:39:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:160001) as
https://chromium.googlesource.com/external/webrtc/+/227f8b9be8866990a4ef34100...

Powered by Google App Engine
This is Rietveld 408576698